From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eydVk-0007wZ-3w for qemu-devel@nongnu.org; Wed, 21 Mar 2018 09:10:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eydVj-0005lX-5O for qemu-devel@nongnu.org; Wed, 21 Mar 2018 09:10:36 -0400 Date: Wed, 21 Mar 2018 09:10:23 -0400 From: Jeff Cody Message-ID: <20180321131023.GP12302@localhost.localdomain> References: <20180320173632.25480-1-kwolf@redhat.com> <20180320173632.25480-12-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180320173632.25480-12-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.12 11/12] vhdx: Check for 4 GB maximum log size on creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, den@openvz.org, eblake@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org On Tue, Mar 20, 2018 at 06:36:31PM +0100, Kevin Wolf wrote: > It's unclear what the real maximum is, but we use an uint32_t to store > the log size in vhdx_co_create(), so we should check that the given > value fits in 32 bits. > It's a uint32 in the on-disk header per spec, so I agree the implied max is UINT32_MAX Reviewed-by: Jeff Cody > Signed-off-by: Kevin Wolf > --- > block/vhdx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/block/vhdx.c b/block/vhdx.c > index 0e48179b81..a1a0302799 100644 > --- a/block/vhdx.c > +++ b/block/vhdx.c > @@ -1829,6 +1829,10 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, > if (!vhdx_opts->has_log_size) { > log_size = DEFAULT_LOG_SIZE; > } else { > + if (vhdx_opts->log_size > UINT32_MAX) { > + error_setg(errp, "Log size must be smaller than 4 GB"); > + return -EINVAL; > + } > log_size = vhdx_opts->log_size; > } > if (log_size < MiB || (log_size % MiB) != 0) { > -- > 2.13.6 >