[Qemu-devel] [PSA] changelog and pull requests

[Qemu-devel] [PSA] changelog and pull requests

[Paolo Bonzini]

Hi all!

If you are receiving this email, you have sent a pull request for QEMU
2.12!  That's awesome, and some of you have also updated the ChangeLog
for the upcoming release, which is doubly awesome!  I'm sure Santa will
put you on the nice list and you can stop reading this email. :)

Even if you haven't updated the ChangeLog, don't worry, I have done it
for you.  Please double check because QEMU is too big for one person to
understand all the changes that were made.

Some of you have spent time throughout the release to write nice
messages for the pull requests.  That's very good too, and hopefully
that has helped me and the ChangeLog entries for your subsystems are
already acceptable.

Whoever remains, you have tagged your updates with messages like "xxx
pull request".  Please don't do this, and please do double check the
2.12 page on the wiki because chances are that I have missed or
misunderstood something (no maintainer with poor tag messages has
updated the ChangeLog[1]).

Please, please think of the poor person who has spent about one hour
collecting all your changes, and use 2 minutes after typing "git tag",
while compiling the code one last time, to put together a short
description of what is happening (especially features and user-visible
hanges) in your pull request.

To put it clearly: all that should be needed in order to write the 2.13
ChangeLog should be "git log --merges --reverse v2.12.0..", and that's
exactly what I'll do three months from now: if you don't write good
messages for your tags, you'll have to write the ChangeLog for your
subsystems yourself.

Thanks,

Paolo

[1] If you did update the ChangeLog, you were supposed to stop reading,
weren't you?

Re: [Qemu-devel] [PSA] changelog and pull requests

[Eric Blake]

On 03/21/2018 10:58 AM, Paolo Bonzini wrote:
> Hi all!
> 
> If you are receiving this email, you have sent a pull request for QEMU
> 2.12!  That's awesome, and some of you have also updated the ChangeLog
> for the upcoming release, which is doubly awesome!  I'm sure Santa will
> put you on the nice list and you can stop reading this email. :)
> 
> Even if you haven't updated the ChangeLog, don't worry, I have done it
> for you.  Please double check because QEMU is too big for one person to
> understand all the changes that were made.

This link is helpful, if you fell in the "I have to keep reading" camp:

https://wiki.qemu.org/ChangeLog/2.12

> [1] If you did update the ChangeLog, you were supposed to stop reading,
> weren't you?

Huh?  /me looks around...
Were you talking to me?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PSA] changelog and pull requests

[Greg Kurz]

On Wed, 21 Mar 2018 12:21:40 -0500
Eric Blake <eblake@redhat.com> wrote:

> On 03/21/2018 10:58 AM, Paolo Bonzini wrote:
> > Hi all!
> > 
> > If you are receiving this email, you have sent a pull request for QEMU
> > 2.12!  That's awesome, and some of you have also updated the ChangeLog
> > for the upcoming release, which is doubly awesome!  I'm sure Santa will
> > put you on the nice list and you can stop reading this email. :)
> > 
> > Even if you haven't updated the ChangeLog, don't worry, I have done it
> > for you.  Please double check because QEMU is too big for one person to
> > understand all the changes that were made.  
> 
> This link is helpful, if you fell in the "I have to keep reading" camp:
> 
> https://wiki.qemu.org/ChangeLog/2.12
> 
> > [1] If you did update the ChangeLog, you were supposed to stop reading,
> > weren't you?  
> 
> Huh?  /me looks around...
> Were you talking to me?
> 

Heh, same here... I couldn't resist :)

--
Greg

Re: [Qemu-devel] [PSA] changelog and pull requests

[BALATON Zoltan]

On Wed, 21 Mar 2018, Paolo Bonzini wrote:
> Even if you haven't updated the ChangeLog, don't worry, I have done it
> for you.  Please double check because QEMU is too big for one person to
> understand all the changes that were made.

Thanks for updating the ChangeLog. Best sources of info for the sam460ex 
machine type are probably the cover letters of the patches I've sent: 
http://lists.nongnu.org/archive/html/qemu-ppc/2018-02/msg00189.html
(and the one linked from it which is still mostly true).

This is a single machine so the "New Sam460ex machine types." should 
probably be singular. Maybe it also worth mentioning that a new SATA 
controller emulation, sii3112 was added (that is used by this machine but 
it's a generic PCI card so might be useful elsewhere although it's 
currently only compiled for PPC machines and not very well tested). I 
think also the SM501 emulation had some improvements in this version or 
was that already in 2.11? (Sam460ex uses this too apart from the SH 
machines). For this whole machine it's true that it's kind of preliminary 
and has a lot of missing parts yet so furhter testing and contributions 
are welcome to improve it. I think this should be stated whenever sam460ex 
is mentioned now so people who want to try it know what to expect and 
don't get the impression that it's a finished full emulation.

Regards,
BALATON Zoltan