qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, marcandre.lureau@gmail.com
Subject: Re: [Qemu-devel] [PATCH v5.2 for 2.13 0/4] tpm: Extend TPM with state migration support
Date: Wed, 21 Mar 2018 20:04:41 +0000	[thread overview]
Message-ID: <20180321200440.GA3466@work-vm> (raw)
In-Reply-To: <1521253498-6834-1-git-send-email-stefanb@linux.vnet.ibm.com>

* Stefan Berger (stefanb@linux.vnet.ibm.com) wrote:
> This series of patches implements support for migrating the state of the
> external 'swtpm' TPM emulator as well as that of the TIS interface. 
> 
> For testing of TPM 2 (migration) please use the following git repos and
> branches:
> 
> libtpms: 
>    - repo: https://github.com/stefanberger/libtpms
>    - branch: tpm2-preview.rev146.v2
> 
> swtpm:
>    - repo: https://github.com/stefanberger/swtpm
>    - branch: tpm2-preview.rev146.v2

I don't see that branch in the swtpm tree:
[dgilbert@dgilbert-t530 swtpm]$ git branch -a
* (HEAD detached at origin/master)
  master
  remotes/origin/HEAD -> origin/master
  remotes/origin/coverity_scan
  remotes/origin/master
  remotes/origin/master.next
  remotes/origin/tpm2-preview
  remotes/origin/tpm2-preview.v2

(I need to untangle my system libtpms from that specific version to get it to build as
well)

Dave

> Regards,
>   Stefan
> 
> Changes:
>  v4->v5:
>    - followed Marc-André's and Alan's comments where possible; some comments
>      were not addressed and reasons posted to mailing list
>    - converted debug statements to tracing
>    - qemu_chr_fe_read_all does not return errno, so displaying expected versus
>      received number of bytes rather than strerror(errno)
>    - added test cases
>    - added documentation for migration to docs/spec/tpm.txt
> 
>  v3->v4:
>    - dropped the size limit enforcement on blobs received from the swtpm
>    - the .post_load migration function requires errno's to be returned.
>      -> some of the functions have been converted to return a better errno
> 
> 
> Stefan Berger (4):
>   tpm: extend TPM emulator with state migration support
>   tpm: extend TPM TIS with state migration support
>   docs: tpm: add VM save/restore example and troubleshooting guide
>   tpm: Add test cases that uses the external swtpm with CRB interface
> 
>  docs/specs/tpm.txt         | 106 +++++++++++++++
>  hw/tpm/tpm_emulator.c      | 318 +++++++++++++++++++++++++++++++++++++++++++--
>  hw/tpm/tpm_tis.c           |  52 +++++++-
>  hw/tpm/trace-events        |   9 +-
>  tests/Makefile.include     |   3 +
>  tests/tpm-crb-swtpm-test.c | 244 ++++++++++++++++++++++++++++++++++
>  tests/tpm-util.c           | 143 ++++++++++++++++++++
>  tests/tpm-util.h           |  36 +++++
>  8 files changed, 897 insertions(+), 14 deletions(-)
>  create mode 100644 tests/tpm-crb-swtpm-test.c
>  create mode 100644 tests/tpm-util.c
>  create mode 100644 tests/tpm-util.h
> 
> -- 
> 2.5.5
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  parent reply	other threads:[~2018-03-21 20:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17  2:24 [Qemu-devel] [PATCH v5.2 for 2.13 0/4] tpm: Extend TPM with state migration support Stefan Berger
2018-03-17  2:24 ` [Qemu-devel] [PATCH v5.2 for 2.13 1/4] tpm: extend TPM emulator " Stefan Berger
2018-03-21 17:14   ` Dr. David Alan Gilbert
2018-03-21 21:57     ` Stefan Berger
2018-03-22  9:07       ` Dr. David Alan Gilbert
2018-03-17  2:24 ` [Qemu-devel] [PATCH v5.2 for 2.13 2/4] tpm: extend TPM TIS " Stefan Berger
2018-03-21 18:21   ` Dr. David Alan Gilbert
2018-03-17  2:24 ` [Qemu-devel] [PATCH v5.2 for 2.13 3/4] docs: tpm: add VM save/restore example and troubleshooting guide Stefan Berger
2018-03-21 18:42   ` Dr. David Alan Gilbert
2018-03-21 22:19     ` Stefan Berger
2018-03-23 20:13       ` Dr. David Alan Gilbert
2018-03-17  2:24 ` [Qemu-devel] [PATCH v5.2 for 2.13 4/4] tpm: Add test cases that uses the external swtpm with CRB interface Stefan Berger
2018-03-21 19:51   ` Dr. David Alan Gilbert
2018-03-28 15:56   ` Marc-André Lureau
2018-03-21 20:04 ` Dr. David Alan Gilbert [this message]
2018-03-21 21:48   ` [Qemu-devel] [PATCH v5.2 for 2.13 0/4] tpm: Extend TPM with state migration support Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321200440.GA3466@work-vm \
    --to=dgilbert@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).