From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] coroutine: avoid co_queue_wakeup recursion
Date: Thu, 22 Mar 2018 15:28:31 +0000 [thread overview]
Message-ID: <20180322152834.12656-1-stefanha@redhat.com> (raw)
co_queue_wakeup is currently implemented in a recursive fashion. Pathological
patterns of aio_co_enter() between coroutines can cause stack exhaustion.
This patch series implements co_queue_wakeup iteratively and avoids stack
exhaustion.
This issue was originally reported with qemu-img convert but I don't have a
good reproducer. See Patch 3 for a test-aio test case instead.
Stefan Hajnoczi (3):
queue: add QSIMPLEQ_PREPEND()
coroutine: avoid co_queue_wakeup recursion
coroutine: add test-aio coroutine queue chaining test case
include/qemu/coroutine_int.h | 1 -
include/qemu/queue.h | 8 ++++
block/io.c | 3 +-
tests/test-aio.c | 65 ++++++++++++++++++++-----
util/qemu-coroutine-lock.c | 34 -------------
util/qemu-coroutine.c | 110 +++++++++++++++++++++++--------------------
6 files changed, 120 insertions(+), 101 deletions(-)
--
2.14.3
next reply other threads:[~2018-03-22 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 15:28 Stefan Hajnoczi [this message]
2018-03-22 15:28 ` [Qemu-devel] [PATCH 1/3] queue: add QSIMPLEQ_PREPEND() Stefan Hajnoczi
2018-03-22 15:28 ` [Qemu-devel] [PATCH 2/3] coroutine: avoid co_queue_wakeup recursion Stefan Hajnoczi
2018-03-22 15:28 ` [Qemu-devel] [PATCH 3/3] coroutine: add test-aio coroutine queue chaining test case Stefan Hajnoczi
2018-03-22 16:41 ` [Qemu-devel] [PATCH 0/3] coroutine: avoid co_queue_wakeup recursion Paolo Bonzini
2018-03-27 12:11 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322152834.12656-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).