From: "Richard W.M. Jones" <rjones@redhat.com>
To: Michael Clark <mjc@sifive.com>, dj@redhat.com
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug
Date: Thu, 22 Mar 2018 22:09:24 +0000 [thread overview]
Message-ID: <20180322220924.GJ2787@redhat.com> (raw)
In-Reply-To: <CAHNT7NsJBVruEQq1kR53wpadizjaHzJ5M-8D3_grmSzeogmtZA@mail.gmail.com>
On Thu, Mar 22, 2018 at 02:06:24PM -0700, Michael Clark wrote:
> On Mon, Mar 19, 2018 at 2:39 PM, Michael Clark <mjc@sifive.com> wrote:
> > On Mon, Mar 19, 2018 at 12:42 PM, Richard W.M. Jones <rjones@redhat.com>
> > wrote:
> >> Did you see the problem with restoring floating point registers on
> >> context switch? The test case is quite simple:
> >>
> >> http://oirase.annexia.org/tmp/sched.c
> >
> > No I didn't. Thanks.
> From my local testing, it appears to only show up with SMP enabled. With 1
> CPU enabled the sched.c test passes.
> I'll could try and revert this and see if it makes any difference...
> however I think the float code has changed substantially with respect to
> handling of flags. We could backport the more conservative approach of
> handling MSTATUS_FS in the float routines. We should also run the test case
> on hardware to rule out linux-kernel MSTATUS_FS bugs...
DJ, am I remembering correctly that you tried the test case on the
HiFive evaluation board and it didn't demonstrate the bug?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2018-03-22 22:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 17:26 [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug Michael Clark
2018-03-18 23:22 ` Philippe Mathieu-Daudé
2018-03-19 18:35 ` Michael Clark
2018-03-19 19:42 ` Richard W.M. Jones
2018-03-19 21:39 ` Michael Clark
2018-03-22 21:06 ` Michael Clark
2018-03-22 22:09 ` Richard W.M. Jones [this message]
2018-03-22 22:17 ` DJ Delorie
2018-03-22 22:21 ` Michael Clark
2018-03-23 20:01 ` Palmer Dabbelt
2018-03-20 4:43 ` Richard Henderson
2018-03-20 18:06 ` Michael Clark
2018-03-24 4:35 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322220924.GJ2787@redhat.com \
--to=rjones@redhat.com \
--cc=dj@redhat.com \
--cc=f4bug@amsat.org \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).