From: Peter Xu <peterx@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Fam Zheng <famz@redhat.com>, Juan Quintela <quintela@redhat.com>,
mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>,
marcandre.lureau@redhat.com,
Stefan Hajnoczi <shajnocz@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Auger Eric <eric.auger@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed
Date: Fri, 23 Mar 2018 21:01:17 +0800 [thread overview]
Message-ID: <20180323130117.GP32362@xz-mi> (raw)
In-Reply-To: <332a9ef5-549a-d329-ec5e-d68609b1fbe1@de.ibm.com>
On Fri, Mar 23, 2018 at 01:44:54PM +0100, Christian Borntraeger wrote:
>
>
> On 03/23/2018 01:25 PM, Peter Xu wrote:
> > On Fri, Mar 23, 2018 at 01:10:51PM +0100, Christian Borntraeger wrote:
> >> As Max Reitz said, this breaks several qemu iotests. I can reproduce that on s390
> >> e.g. with ./check -qcow2 030 in the qemu-iotest.
> >>
> >> Why was this merged?
> >
> > My fault. Sorry. I should have done iotests before submission.
> >
> > Now I'm trying to fix those iotest issues.
> >
> > I'm not extremely familiar with block, so the progress is a bit slow,
> > but I'll do it asap (though I'll possibly need some help from the
> > block team, since there are some not-easy ones for me).
>
> As this patch also seems to trigger something else for Eric, can we revert this
> patch for the time being and re-apply as soon as we have solutions for the issues?
>
> After all a hard hang in the iotest can break CI environments (as you run into timeouts).
I'm fine with it if it helps.
Then I can work in background to solved existing problems, then we
turn it on again in 2.13 when ready (but still it might break things -
at least it can be during dev cycle rather than softfreeze).
--
Peter Xu
next prev parent reply other threads:[~2018-03-23 13:01 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 8:59 [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 01/23] docs: update QMP documents for OOB commands Peter Xu
2018-03-09 17:13 ` Eric Blake
2018-03-12 3:32 ` Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 02/23] qobject: introduce qstring_get_try_str() Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 03/23] qobject: introduce qobject_get_try_str() Peter Xu
2018-03-09 20:10 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 04/23] qobject: let object_property_get_str() use new API Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 05/23] monitor: move skip_flush into monitor_data_init Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 06/23] monitor: move the cur_mon hack deeper for QMP Peter Xu
2018-03-10 23:13 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 07/23] monitor: unify global init Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 08/23] monitor: let mon_list be tail queue Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 09/23] monitor: allow using IO thread for parsing Peter Xu
2018-03-10 23:19 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 10/23] qmp: introduce QMPCapability Peter Xu
2018-03-11 1:25 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 11/23] monitor: introduce monitor_qmp_respond() Peter Xu
2018-03-11 1:35 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 12/23] monitor: let suspend_cnt be thread safe Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 13/23] monitor: let suspend/resume work even with QMPs Peter Xu
2018-03-11 1:53 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 14/23] monitor: separate QMP parser and dispatcher Peter Xu
2018-03-11 2:00 ` Eric Blake
2018-03-21 18:01 ` Marc-André Lureau
2018-03-21 20:09 ` Dr. David Alan Gilbert
2018-03-21 20:33 ` Eric Blake
2018-03-21 23:32 ` Marc-André Lureau
2018-03-22 5:00 ` Peter Xu
2018-03-22 13:24 ` Eric Blake
2018-03-23 16:18 ` Marc-André Lureau
2018-03-26 8:07 ` Peter Xu
2018-03-26 8:33 ` Marc-André Lureau
2018-03-26 9:08 ` Peter Xu
2018-03-26 9:46 ` Marc-André Lureau
2018-03-28 4:02 ` Peter Xu
2018-04-04 13:58 ` Marc-André Lureau
2018-04-08 3:02 ` Peter Xu
2018-04-09 9:19 ` Marc-André Lureau
2018-04-10 7:15 ` Peter Xu
2018-04-10 7:56 ` Peter Xu
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 15/23] qmp: add new event "command-dropped" Peter Xu
2018-03-11 2:03 ` Eric Blake
2018-03-09 8:59 ` [Qemu-devel] [PATCH v8 16/23] monitor: send event when command queue full Peter Xu
2018-03-11 2:11 ` Eric Blake
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 17/23] qapi: introduce new cmd option "allow-oob" Peter Xu
2018-03-11 2:27 ` Eric Blake
2018-03-12 3:35 ` Peter Xu
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 18/23] qmp: support out-of-band (oob) execution Peter Xu
2018-03-11 2:37 ` Eric Blake
2018-03-22 10:22 ` Marc-André Lureau
2018-03-23 5:18 ` Peter Xu
2018-03-23 10:03 ` Marc-André Lureau
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 19/23] qmp: isolate responses into io thread Peter Xu
2018-03-22 12:00 ` Marc-André Lureau
2018-03-23 5:50 ` Peter Xu
2018-03-23 10:00 ` Marc-André Lureau
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2018-03-23 12:10 ` Christian Borntraeger
2018-03-23 12:25 ` Peter Xu
2018-03-23 12:44 ` Christian Borntraeger
2018-03-23 13:01 ` Peter Xu [this message]
2018-03-23 13:21 ` Peter Maydell
2018-03-23 13:23 ` Christian Borntraeger
2018-03-23 13:39 ` Peter Xu
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 21/23] qmp: add command "x-oob-test" Peter Xu
2018-03-11 2:42 ` Eric Blake
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching Peter Xu
2018-03-11 2:45 ` Eric Blake
2018-03-12 3:43 ` Peter Xu
2018-03-09 9:00 ` [Qemu-devel] [PATCH v8 23/23] tests: qmp-test: add oob test Peter Xu
2018-03-11 2:49 ` Eric Blake
2018-03-12 3:56 ` Peter Xu
2018-03-11 2:59 ` [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support Eric Blake
2018-03-12 4:14 ` Peter Xu
2018-03-12 12:01 ` Eric Blake
2018-03-12 12:55 ` Daniel P. Berrangé
2018-03-13 2:06 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323130117.GP32362@xz-mi \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=famz@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).