From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNNn-0007YB-1D for qemu-devel@nongnu.org; Fri, 23 Mar 2018 10:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNNj-0005Jp-SN for qemu-devel@nongnu.org; Fri, 23 Mar 2018 10:09:26 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49924 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezNNj-0005Im-PG for qemu-devel@nongnu.org; Fri, 23 Mar 2018 10:09:23 -0400 From: Peter Xu Date: Fri, 23 Mar 2018 22:08:20 +0800 Message-Id: <20180323140821.28957-4-peterx@redhat.com> In-Reply-To: <20180323140821.28957-1-peterx@redhat.com> References: <20180323140821.28957-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify command batching" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Daniel P . Berrange" , Christian Borntraeger , Fam Zheng , Kevin Wolf , Max Reitz , peterx@redhat.com, Eric Auger , Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , John Snow , Markus Armbruster , Peter Maydell This reverts commit 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8. Signed-off-by: Peter Xu --- tests/qmp-test.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/tests/qmp-test.c b/tests/qmp-test.c index 2e4b599a4c..d1fa1cb217 100644 --- a/tests/qmp-test.c +++ b/tests/qmp-test.c @@ -82,7 +82,6 @@ static void test_qmp_protocol(void) QTestState *qts; const QListEntry *entry; QString *qstr; - int i; qts = qtest_init_without_qmp_handshake(common_args); @@ -140,27 +139,6 @@ static void test_qmp_protocol(void) g_assert_cmpint(qdict_get_int(resp, "id"), ==, 2); QDECREF(resp); - /* - * Test command batching. In current test OOB is not enabled, we - * should be able to run as many commands in batch as we like. - * Using 16 (>8, which is OOB queue length) to make sure OOB won't - * break existing clients. Note: this test does not control the - * scheduling of QEMU's QMP command processing threads so it may - * not really trigger batching inside QEMU. This is just a - * best-effort test. - */ - for (i = 0; i < 16; i++) { - qtest_async_qmp(qts, "{ 'execute': 'query-version' }"); - } - /* Verify the replies to make sure no command is dropped. */ - for (i = 0; i < 16; i++) { - resp = qtest_qmp_receive(qts); - /* It should never be dropped. Each of them should be a reply. */ - g_assert(qdict_haskey(resp, "return")); - g_assert(!qdict_haskey(resp, "event")); - QDECREF(resp); - } - qtest_quit(qts); } -- 2.14.3