From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com, mst@redhat.com,
marcel@redhat.com, f4bug@amsat.org, eblake@redhat.com,
berrange@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH PULL 7/8] hw/rdma: Use correct print format in CHK_ATTR macro
Date: Fri, 23 Mar 2018 18:53:05 +0300 [thread overview]
Message-ID: <20180323155306.83812-8-marcel@redhat.com> (raw)
In-Reply-To: <20180323155306.83812-1-marcel@redhat.com>
From: Yuval Shaia <yuval.shaia@oracle.com>
Macro should not cast the given variable to u64 instead it should use
the supplied format argument (fmt).
Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180322095220.9976-3-yuval.shaia@oracle.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/rdma/rdma_backend.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index b1d2913b2c..1dbb17bd2e 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -668,8 +668,8 @@ void rdma_backend_destroy_qp(RdmaBackendQP *qp)
#define CHK_ATTR(req, dev, member, fmt) ({ \
pr_dbg("%s="fmt","fmt"\n", #member, dev.member, req->member); \
if (req->member > dev.member) { \
- warn_report("%s = 0x%lx is higher than host device capability 0x%lx", \
- #member, (uint64_t)req->member, (uint64_t)dev.member); \
+ warn_report("%s = "fmt" is higher than host device capability "fmt, \
+ #member, req->member, dev.member); \
req->member = dev.member; \
} \
pr_dbg("%s="fmt"\n", #member, req->member); })
--
2.13.5
next prev parent reply other threads:[~2018-03-23 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 15:52 [Qemu-devel] [PATCH PULL 0/8] RDMA queue Marcel Apfelbaum
2018-03-23 15:52 ` [Qemu-devel] [PATCH PULL 1/8] hw/rdma: Add Query QP operation Marcel Apfelbaum
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 2/8] hw/rdma: Add support for Query QP verb to pvrdma device Marcel Apfelbaum
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 3/8] rdma: fix up include directives Marcel Apfelbaum
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 4/8] make: switch from -I to -iquote Marcel Apfelbaum
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 5/8] hw/rdma: fix clang compilation errors Marcel Apfelbaum
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 6/8] hw/rdma: Change host_virt to void * Marcel Apfelbaum
2018-03-23 15:53 ` Marcel Apfelbaum [this message]
2018-03-23 15:53 ` [Qemu-devel] [PATCH PULL 8/8] hw/rdma: Fix 32-bit compilation Marcel Apfelbaum
2018-03-24 19:23 ` [Qemu-devel] [PATCH PULL 0/8] RDMA queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323155306.83812-8-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).