From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, berrange@redhat.com, lidongchen@tencent.com,
pl@kamp.de, peterx@redhat.com
Subject: [Qemu-devel] [PULL 3/5] migration/block: limit the number of parallel I/O requests
Date: Fri, 23 Mar 2018 20:23:42 +0000 [thread overview]
Message-ID: <20180323202344.70640-4-dgilbert@redhat.com> (raw)
In-Reply-To: <20180323202344.70640-1-dgilbert@redhat.com>
From: Peter Lieven <pl@kamp.de>
the current implementation submits up to 512 I/O requests in parallel
which is much to high especially for a background task.
This patch adds a maximum limit of 16 I/O requests that can
be submitted in parallel to avoid monopolizing the I/O device.
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1520507908-16743-5-git-send-email-pl@kamp.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/block.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/block.c b/migration/block.c
index 5c03632257..03bbba61cb 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -37,6 +37,7 @@
#define MAX_IS_ALLOCATED_SEARCH (65536 * BDRV_SECTOR_SIZE)
#define MAX_IO_BUFFERS 512
+#define MAX_PARALLEL_IO 16
//#define DEBUG_BLK_MIGRATION
@@ -775,6 +776,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
while ((block_mig_state.submitted +
block_mig_state.read_done) * BLOCK_SIZE <
qemu_file_get_rate_limit(f) &&
+ block_mig_state.submitted < MAX_PARALLEL_IO &&
(block_mig_state.submitted + block_mig_state.read_done) <
MAX_IO_BUFFERS) {
blk_mig_unlock();
--
2.14.3
next prev parent reply other threads:[~2018-03-23 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:23 [Qemu-devel] [PULL 0/5] migration queue Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 1/5] migration: convert socket server to QIONetListener Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 2/5] migration: Fix rate limiting issue on RDMA migration Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` Dr. David Alan Gilbert (git) [this message]
2018-03-23 20:23 ` [Qemu-devel] [PULL 4/5] migration/block: compare only read blocks against the rate limiter Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 5/5] migration: Fix block migration flag case Dr. David Alan Gilbert (git)
2018-03-24 21:53 ` [Qemu-devel] [PULL 0/5] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323202344.70640-4-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=lidongchen@tencent.com \
--cc=peterx@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).