From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, berrange@redhat.com, lidongchen@tencent.com,
pl@kamp.de, peterx@redhat.com
Subject: [Qemu-devel] [PULL 5/5] migration: Fix block migration flag case
Date: Fri, 23 Mar 2018 20:23:44 +0000 [thread overview]
Message-ID: <20180323202344.70640-6-dgilbert@redhat.com> (raw)
In-Reply-To: <20180323202344.70640-1-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Fix the case where when a migration with a bad protocol is tried,
we leave the block migration capability set.
(This is a cut down version of my 'migration: Fix block failure cases'
where it's other case was fixed by Peter's dd0ee30caeebbd )
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20180316202114.32345-1-dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index fc629e5965..52a5092add 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1428,6 +1428,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
"a valid migration protocol");
migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
MIGRATION_STATUS_FAILED);
+ block_cleanup_parameters(s);
return;
}
--
2.14.3
next prev parent reply other threads:[~2018-03-23 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:23 [Qemu-devel] [PULL 0/5] migration queue Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 1/5] migration: convert socket server to QIONetListener Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 2/5] migration: Fix rate limiting issue on RDMA migration Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 3/5] migration/block: limit the number of parallel I/O requests Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` [Qemu-devel] [PULL 4/5] migration/block: compare only read blocks against the rate limiter Dr. David Alan Gilbert (git)
2018-03-23 20:23 ` Dr. David Alan Gilbert (git) [this message]
2018-03-24 21:53 ` [Qemu-devel] [PULL 0/5] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323202344.70640-6-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=lidongchen@tencent.com \
--cc=peterx@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).