From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
jsnow@redhat.com, famz@redhat.com, vsementsov@virtuozzo.com,
den@openvz.org
Subject: [Qemu-devel] [PATCH 5.5/7] dirty-bitmap: drop unused bdrv_undo_clear_dirty_bitmap
Date: Mon, 26 Mar 2018 14:53:46 +0300 [thread overview]
Message-ID: <20180326115346.11939-1-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20180326112056.8420-1-vsementsov@virtuozzo.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
include/block/block_int.h | 1 -
block/dirty-bitmap.c | 9 ---------
2 files changed, 10 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index e5af7820ff..bd857d5099 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -1079,7 +1079,6 @@ bool blk_dev_is_medium_locked(BlockBackend *blk);
void bdrv_set_dirty(BlockDriverState *bs, int64_t offset, int64_t bytes);
void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out);
-void bdrv_undo_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *in);
void bdrv_inc_in_flight(BlockDriverState *bs);
void bdrv_dec_in_flight(BlockDriverState *bs);
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 1812e17549..3c69a8eed9 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -607,15 +607,6 @@ void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap **out)
bdrv_dirty_bitmap_unlock(bitmap);
}
-void bdrv_undo_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *in)
-{
- HBitmap *tmp = bitmap->bitmap;
- assert(bdrv_dirty_bitmap_enabled(bitmap));
- assert(!bdrv_dirty_bitmap_readonly(bitmap));
- bitmap->bitmap = in;
- hbitmap_free(tmp);
-}
-
uint64_t bdrv_dirty_bitmap_serialization_size(const BdrvDirtyBitmap *bitmap,
uint64_t offset, uint64_t bytes)
{
--
2.11.1
next prev parent reply other threads:[~2018-03-26 11:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:20 [Qemu-devel] [PATCH 0/7] Dirty bitmaps fixing and refactoring Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 3/7] dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 4/7] dirty-bitmap: separate unused meta-bitmap related functions Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 5/7] blockdev: refactor block-dirty-bitmap-clear transaction Vladimir Sementsov-Ogievskiy
2018-03-26 11:44 ` Paolo Bonzini
2018-03-26 11:48 ` Vladimir Sementsov-Ogievskiy
2018-03-26 11:53 ` Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter Vladimir Sementsov-Ogievskiy
2018-03-26 11:20 ` [Qemu-devel] [PATCH 7/7] blockdev: unify block-dirty-bitmap-clear command and transaction action Vladimir Sementsov-Ogievskiy
2018-03-26 11:44 ` [Qemu-devel] [PATCH 0/7] Dirty bitmaps fixing and refactoring Paolo Bonzini
2018-03-26 11:53 ` Vladimir Sementsov-Ogievskiy [this message]
2018-03-26 13:21 ` [Qemu-devel] [PATCH 5.5/7] dirty-bitmap: drop unused bdrv_undo_clear_dirty_bitmap no-reply
2018-03-26 14:21 ` no-reply
2018-03-26 15:56 ` no-reply
2018-03-26 17:04 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326115346.11939-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).