qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 13/19] qemu-iotests: Test invalid resize on luks
Date: Mon, 26 Mar 2018 16:35:54 +0200	[thread overview]
Message-ID: <20180326143600.7724-14-kwolf@redhat.com> (raw)
In-Reply-To: <20180326143600.7724-1-kwolf@redhat.com>

This tests that the .bdrv_truncate implementation for luks doesn't crash
for invalid image sizes.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 tests/qemu-iotests/210     | 37 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/210.out | 16 ++++++++++++++++
 2 files changed, 53 insertions(+)

diff --git a/tests/qemu-iotests/210 b/tests/qemu-iotests/210
index 96a5213e77..e607c0d296 100755
--- a/tests/qemu-iotests/210
+++ b/tests/qemu-iotests/210
@@ -204,6 +204,43 @@ run_qemu -blockdev driver=file,filename="$TEST_IMG_FILE",node-name=node0 \
 { "execute": "quit" }
 EOF
 
+echo
+echo "=== Resize image with invalid sizes ==="
+echo
+
+run_qemu -blockdev driver=file,filename="$TEST_IMG_FILE",node-name=node0 \
+         -blockdev driver=luks,file=node0,key-secret=keysec0,node-name=node1 \
+         -object secret,id=keysec0,data="foo" <<EOF
+{ "execute": "qmp_capabilities" }
+{ "execute": "block_resize",
+  "arguments": {
+      "node-name": "node1",
+      "size": 9223372036854775296
+  }
+}
+{ "execute": "block_resize",
+  "arguments": {
+      "node-name": "node1",
+      "size": 9223372036854775808
+  }
+}
+{ "execute": "block_resize",
+  "arguments": {
+      "node-name": "node1",
+      "size": 18446744073709551104
+  }
+}
+{ "execute": "block_resize",
+  "arguments": {
+      "node-name": "node1",
+      "size": -9223372036854775808
+  }
+}
+{ "execute": "quit" }
+EOF
+
+_img_info | _filter_img_info
+
 # success, all done
 echo "*** done"
 rm -f $seq.full
diff --git a/tests/qemu-iotests/210.out b/tests/qemu-iotests/210.out
index 8fcab65909..8198f8c829 100644
--- a/tests/qemu-iotests/210.out
+++ b/tests/qemu-iotests/210.out
@@ -133,4 +133,20 @@ QMP_VERSION
 {"return": {}}
 {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false}}
 
+
+=== Resize image with invalid sizes ===
+
+Testing: -blockdev driver=file,filename=TEST_DIR/t.IMGFMT,node-name=node0 -blockdev driver=IMGFMT,file=node0,key-secret=keysec0,node-name=node1 -object secret,id=keysec0,data=foo
+QMP_VERSION
+{"return": {}}
+{"error": {"class": "GenericError", "desc": "The requested file size is too large"}}
+{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'size', expected: integer"}}
+{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'size', expected: integer"}}
+{"error": {"class": "GenericError", "desc": "Parameter 'size' expects a >0 size"}}
+{"return": {}}
+{"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false}}
+
+image: json:{"driver": "IMGFMT", "file": {"driver": "file", "filename": "TEST_DIR/t.IMGFMT"}, "key-secret": "keysec0"}
+file format: IMGFMT
+virtual size: 0 (0 bytes)
 *** done
-- 
2.13.6

  parent reply	other threads:[~2018-03-26 14:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 14:35 [Qemu-devel] [PULL 00/19] Block layer patches Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 01/19] iotests: 163 is not quick Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 02/19] block/replication: Remove protocol_name field Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 03/19] block/quorum: Remove protocol-related fields Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 04/19] block/throttle: " Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 05/19] block/blkreplay: " Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 06/19] include/block/block_int: Document protocol related functions Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 07/19] qcow2: Reset free_cluster_index when allocating a new refcount block Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 08/19] vdi: Change 'static' create option to 'preallocation' in QMP Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 09/19] vdi: Fix build with CONFIG_VDI_DEBUG Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 10/19] qemu-iotests: Test vdi image creation with QMP Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 11/19] qemu-iotests: Enable 025 for luks Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 12/19] luks: Turn another invalid assertion into check Kevin Wolf
2018-03-26 14:35 ` Kevin Wolf [this message]
2018-03-26 14:35 ` [Qemu-devel] [PULL 14/19] parallels: Check maximum cluster size on create Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 15/19] qemu-iotests: Test parallels image creation with QMP Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 16/19] vhdx: Require power-of-two block size on create Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 17/19] vhdx: Don't use error_setg_errno() with constant errno Kevin Wolf
2018-03-26 14:35 ` [Qemu-devel] [PULL 18/19] vhdx: Check for 4 GB maximum log size on creation Kevin Wolf
2018-03-26 14:36 ` [Qemu-devel] [PULL 19/19] qemu-iotests: Test vhdx image creation with QMP Kevin Wolf
2018-03-27  9:27 ` [Qemu-devel] [PULL 00/19] Block layer patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326143600.7724-14-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).