From: Anthony PERARD <anthony.perard@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,
sstabellini@kernel.org, paul.durrant@citrix.com,
pbonzini@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] xen-pvdevice: Introduce a simplistic xen-pvdevice save state
Date: Tue, 27 Mar 2018 10:42:05 +0100 [thread overview]
Message-ID: <20180327094204.GC2208@perard> (raw)
In-Reply-To: <1520982894-4180-1-git-send-email-igor.druzhinin@citrix.com>
On Tue, Mar 13, 2018 at 11:14:54PM +0000, Igor Druzhinin wrote:
> This should help to avoid problems with accessing the device after
> migration/resume without PV drivers by migrating its PCI configuration
> space state. Without an explicitly defined state record it resets
> every time a VM migrates which confuses the OS and makes every
> access to xen-pvdevice MMIO region to fail. PV tools enable some
> logic to save and restore PCI configuration state from within the VM
> every time it migrates which basically hides the issue.
>
> Older systems will acquire the new record when migrated which should
> not change their state for worse.
>
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> v2: add more concrete info
> ---
> hw/i386/xen/xen_pvdevice.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
prev parent reply other threads:[~2018-03-27 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 23:14 [Qemu-devel] [PATCH v2] xen-pvdevice: Introduce a simplistic xen-pvdevice save state Igor Druzhinin
2018-03-27 9:42 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327094204.GC2208@perard \
--to=anthony.perard@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=mst@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).