From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0oL8-0004fl-OD for qemu-devel@nongnu.org; Tue, 27 Mar 2018 09:08:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0oL3-0007lY-PL for qemu-devel@nongnu.org; Tue, 27 Mar 2018 09:08:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57242 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0oL3-0007kf-JY for qemu-devel@nongnu.org; Tue, 27 Mar 2018 09:08:33 -0400 Date: Tue, 27 Mar 2018 15:08:27 +0200 From: Igor Mammedov Message-ID: <20180327150827.532e8486@redhat.com> In-Reply-To: <20180323204218.GC28161@localhost.localdomain> References: <1520860275-101576-1-git-send-email-imammedo@redhat.com> <1520860275-101576-3-git-send-email-imammedo@redhat.com> <20180323204218.GC28161@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, pkrempa@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au On Fri, 23 Mar 2018 17:42:18 -0300 Eduardo Habkost wrote: > On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > > it will allow to reuse parse_NumaOptions() for parsing > > configuration commands received via QMP interface > > > > Signed-off-by: Igor Mammedov > > --- > > include/sysemu/numa.h | 1 + > > numa.c | 48 +++++++++++++++++++++++++++++------------------- > > 2 files changed, 30 insertions(+), 19 deletions(-) > > > > diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h > > index 21713b7..7a0ae75 100644 > > --- a/include/sysemu/numa.h > > +++ b/include/sysemu/numa.h > > @@ -22,6 +22,7 @@ struct NumaNodeMem { > > }; > > > > extern NodeInfo numa_info[MAX_NODES]; > > +int parse_numa(void *opaque, QemuOpts *opts, Error **errp); > > void parse_numa_opts(MachineState *ms); > > void numa_complete_configuration(MachineState *ms); > > void query_numa_node_mem(NumaNodeMem node_mem[]); > > diff --git a/numa.c b/numa.c > > index 126c649..2b1d292 100644 > > --- a/numa.c > > +++ b/numa.c > > @@ -169,28 +169,11 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp) > > have_numa_distance = true; > > } > > > > -static int parse_numa(void *opaque, QemuOpts *opts, Error **errp) > > +static > > +void parse_NumaOptions(MachineState *ms, NumaOptions *object, Error **errp) > > I wonder if we should rename the parse_numa_{node,distance}() > functions to configure_numa_{node,distance}(), and this one > configure_numa(). These functions don't parse anything, anymore. I'd preffer to do it in another patch on top of this series (added it my TODO list) > > { > > - NumaOptions *object = NULL; > > - MachineState *ms = opaque; > > Error *err = NULL; > > > > - { > > - Visitor *v = opts_visitor_new(opts); > > - visit_type_NumaOptions(v, NULL, &object, &err); > > - visit_free(v); > > - } > > - > > - if (err) { > > - goto end; > > - } > > - > > - /* Fix up legacy suffix-less format */ > > - if ((object->type == NUMA_OPTIONS_TYPE_NODE) && object->u.node.has_mem) { > > - const char *mem_str = qemu_opt_get(opts, "mem"); > > - qemu_strtosz_MiB(mem_str, NULL, &object->u.node.mem); > > - } > > - > > switch (object->type) { > > case NUMA_OPTIONS_TYPE_NODE: > > parse_numa_node(ms, &object->u.node, &err); > > @@ -224,6 +207,33 @@ static int parse_numa(void *opaque, QemuOpts *opts, Error **errp) > > } > > > > end: > > + if (err) { > > + error_propagate(errp, err); > > + } > > "if (err)" is not necessary here. See > scripts/coccinelle/error_propagate_null.cocci. fixed > > +} > > + > > +int parse_numa(void *opaque, QemuOpts *opts, Error **errp) > > +{ > > + NumaOptions *object = NULL; > > + MachineState *ms = MACHINE(opaque); > > + Error *err = NULL; > > + Visitor *v = opts_visitor_new(opts); > > + > > + visit_type_NumaOptions(v, NULL, &object, &err); > > + visit_free(v); > > + if (err) { > > + goto end; > > + } > > + > > + /* Fix up legacy suffix-less format */ > > + if ((object->type == NUMA_OPTIONS_TYPE_NODE) && object->u.node.has_mem) { > > + const char *mem_str = qemu_opt_get(opts, "mem"); > > + qemu_strtosz_MiB(mem_str, NULL, &object->u.node.mem); > > + } > > + > > + parse_NumaOptions(ms, object, &err); > > + > > +end: > > qapi_free_NumaOptions(object); > > if (err) { > > error_report_err(err); > > We can fix this one too while at it. error_report_err() doesn't check for NULL value, 'if(err)' is needed here > The rest of the patch looks good. >