From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0pXw-0004UT-Fq for qemu-devel@nongnu.org; Tue, 27 Mar 2018 10:25:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0pXt-0003O0-6e for qemu-devel@nongnu.org; Tue, 27 Mar 2018 10:25:56 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60358 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0pXt-0003Mn-1i for qemu-devel@nongnu.org; Tue, 27 Mar 2018 10:25:53 -0400 Date: Tue, 27 Mar 2018 16:25:42 +0200 From: Cornelia Huck Message-ID: <20180327162542.1517b072.cohuck@redhat.com> In-Reply-To: <686b98e4-cf4e-00c9-e4fd-a3efd9f52994@redhat.com> References: <20180327123800.28851-1-sathnaga@linux.vnet.ibm.com> <686b98e4-cf4e-00c9-e4fd-a3efd9f52994@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.12] hmp.c: Revert hmp_info_cpus output format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: sathnaga@linux.vnet.ibm.com, qemu-devel@nongnu.org, Viktor Mihajlovski On Tue, 27 Mar 2018 08:59:04 -0500 Eric Blake wrote: > On 03/27/2018 07:38 AM, sathnaga@linux.vnet.ibm.com wrote: > > From: Satheesh Rajendran > > > > This commit 137b5cb6ab565cb3781d5337591e155932b4230e > > refactors info cpus output and changes output format from > > 'thread_id' to 'thread-id', this would break parsing > > of output in above layers like libvirt, test framework etc. > > > > This patch just reverts back output format to 'thread_id'. > > > > CC: Viktor Mihajlovski > > Signed-off-by: Satheesh Rajendran > > --- > > hmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I'm not opposed to this patch (because it is a trivial way to keep older > stuff working), but agree with Daniel that HMP output can change at any > time, so other stuff relying on HMP should be fixed. Libvirt is not > affected, so if we DO take this into 2.12, we should update the commit > message to drop mention of libvirt being impacted, maybe along the lines of: > > Commit 137b5cb6 refactored 'info cpus' output, changing 'thread_id' to > 'thread-id'. While HMP is not a stable interface, it is trivial to keep > the spelling consistent for test frameworks that have not yet updated to > using QMP. > > With the improved commit message, > Reviewed-by: Eric Blake > Yes, that certainly makes sense. Reviewed-by: Cornelia Huck