From: Cornelia Huck <cohuck@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
James Hogan <jhogan@kernel.org>,
Roman Kagan <rkagan@virtuozzo.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: add unistd.h and kvm on MIPS
Date: Tue, 27 Mar 2018 16:48:40 +0200 [thread overview]
Message-ID: <20180327164840.78a7d905.cohuck@redhat.com> (raw)
In-Reply-To: <20180323173823.GD17165@work-vm>
On Fri, 23 Mar 2018 17:38:24 +0000
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > @@ -120,6 +124,10 @@ EOF
> > cp "$tmpdir/include/asm/unistd_x32.h" "$output/linux-headers/asm-x86/"
> > cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-x86/"
> > fi
> > + if [ $arch = s390 ]; then
> > + cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-arm/"
> > + cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-arm/"
>
> That doesn't look right - I'm guessing that should be copying into
> asm-s390 ?
I think we rather need "$arch = arm" or so here (s390 only has
unistd.h, which is already handled).
next prev parent reply other threads:[~2018-03-27 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 21:01 [Qemu-devel] [PATCH v4 0/3] linux-headers: arch fixups Michael S. Tsirkin
2018-03-20 21:01 ` [Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: add unistd.h and kvm on MIPS Michael S. Tsirkin
2018-03-23 17:38 ` Dr. David Alan Gilbert
2018-03-27 14:48 ` Cornelia Huck [this message]
2018-03-20 21:01 ` [Qemu-devel] [PATCH v4 2/3] linux-headers: add unistd.h on all arches Michael S. Tsirkin
2018-03-20 21:01 ` [Qemu-devel] [PATCH v4 3/3] linux-headers: add kvm header for mips Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327164840.78a7d905.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jhogan@kernel.org \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).