* [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h
@ 2018-03-28 1:19 Tiwei Bie
2018-03-28 1:28 ` Michael S. Tsirkin
2018-03-28 6:50 ` Auger Eric
0 siblings, 2 replies; 3+ messages in thread
From: Tiwei Bie @ 2018-03-28 1:19 UTC (permalink / raw)
To: alex.williamson, mst; +Cc: qemu-devel
This macro isn't used by any VFIO code. And its name is
too generic. The vfio-common.h (in include/hw/vfio) can
be included by other modules in QEMU. It can introduce
conflicts.
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
include/hw/vfio/vfio-common.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index d9360148e6..cecbd4e386 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -34,15 +34,6 @@
#define ERR_PREFIX "vfio error: %s: "
#define WARN_PREFIX "vfio warning: %s: "
-/*#define DEBUG_VFIO*/
-#ifdef DEBUG_VFIO
-#define DPRINTF(fmt, ...) \
- do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
- do { } while (0)
-#endif
-
enum {
VFIO_DEVICE_TYPE_PCI = 0,
VFIO_DEVICE_TYPE_PLATFORM = 1,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h
2018-03-28 1:19 [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h Tiwei Bie
@ 2018-03-28 1:28 ` Michael S. Tsirkin
2018-03-28 6:50 ` Auger Eric
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2018-03-28 1:28 UTC (permalink / raw)
To: Tiwei Bie; +Cc: alex.williamson, qemu-devel
On Wed, Mar 28, 2018 at 09:19:53AM +0800, Tiwei Bie wrote:
> This macro isn't used by any VFIO code. And its name is
> too generic. The vfio-common.h (in include/hw/vfio) can
> be included by other modules in QEMU. It can introduce
> conflicts.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/vfio/vfio-common.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index d9360148e6..cecbd4e386 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -34,15 +34,6 @@
> #define ERR_PREFIX "vfio error: %s: "
> #define WARN_PREFIX "vfio warning: %s: "
>
> -/*#define DEBUG_VFIO*/
> -#ifdef DEBUG_VFIO
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> enum {
> VFIO_DEVICE_TYPE_PCI = 0,
> VFIO_DEVICE_TYPE_PLATFORM = 1,
> --
> 2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h
2018-03-28 1:19 [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h Tiwei Bie
2018-03-28 1:28 ` Michael S. Tsirkin
@ 2018-03-28 6:50 ` Auger Eric
1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2018-03-28 6:50 UTC (permalink / raw)
To: Tiwei Bie, alex.williamson, mst; +Cc: qemu-devel
Hi,
On 28/03/18 03:19, Tiwei Bie wrote:
> This macro isn't used by any VFIO code. And its name is
> too generic. The vfio-common.h (in include/hw/vfio) can
> be included by other modules in QEMU. It can introduce
> conflicts.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> include/hw/vfio/vfio-common.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index d9360148e6..cecbd4e386 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -34,15 +34,6 @@
> #define ERR_PREFIX "vfio error: %s: "
> #define WARN_PREFIX "vfio warning: %s: "
>
> -/*#define DEBUG_VFIO*/
> -#ifdef DEBUG_VFIO
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> enum {
> VFIO_DEVICE_TYPE_PCI = 0,
> VFIO_DEVICE_TYPE_PLATFORM = 1,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-28 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-28 1:19 [Qemu-devel] [PATCH] vfio: remove DPRINTF() definition from vfio-common.h Tiwei Bie
2018-03-28 1:28 ` Michael S. Tsirkin
2018-03-28 6:50 ` Auger Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).