From: Balamuruhan S <bala24@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, amit.shah@redhat.com,
Balamuruhan S <bala24@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()
Date: Sun, 1 Apr 2018 00:25:36 +0530 [thread overview]
Message-ID: <20180331185536.4835-1-bala24@linux.vnet.ibm.com> (raw)
expected_downtime value is not accurate with dirty_pages_rate * page_size,
using ram_bytes_remaining would yeild it correct.
Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
---
migration/migration.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 58bd382730..4e43dc4f92 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2245,8 +2245,7 @@ static void migration_update_counters(MigrationState *s,
* recalculate. 10000 is a small enough number for our purposes
*/
if (ram_counters.dirty_pages_rate && transferred > 10000) {
- s->expected_downtime = ram_counters.dirty_pages_rate *
- qemu_target_page_size() / bandwidth;
+ s->expected_downtime = ram_bytes_remaining() / bandwidth;
}
qemu_file_reset_rate_limit(s->to_dst_file);
--
2.14.3
next reply other threads:[~2018-03-31 18:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 18:55 Balamuruhan S [this message]
2018-04-03 6:10 ` [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining() Peter Xu
2018-04-03 17:30 ` bala24
2018-04-04 1:59 ` Peter Xu
2018-04-04 9:02 ` Juan Quintela
2018-04-04 9:04 ` Juan Quintela
2018-04-10 9:52 ` Balamuruhan S
2018-04-10 10:52 ` Balamuruhan S
-- strict thread matches above, loose matches on Subject: below --
2018-04-04 6:25 Balamuruhan S
2018-04-04 8:06 ` Peter Xu
2018-04-04 8:49 ` Balamuruhan S
2018-04-09 18:57 ` Dr. David Alan Gilbert
2018-04-10 1:22 ` David Gibson
2018-04-10 10:02 ` Dr. David Alan Gilbert
2018-04-11 1:28 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180331185536.4835-1-bala24@linux.vnet.ibm.com \
--to=bala24@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).