qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL 6/8] linux-user: fix error propagation in clock_gettime
Date: Mon,  2 Apr 2018 10:13:52 -0700	[thread overview]
Message-ID: <20180402171354.27706-7-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <20180402171354.27706-1-jcmvbkbc@gmail.com>

host_to_target_timespec may return error if target address could not be
locked, but it is ignored.
Propagate return value of host_to_target_timespec to the caller of
clock_gettime.

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index d51e2a00ee31..52e2f9c16479 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11884,7 +11884,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
         struct timespec ts;
         ret = get_errno(clock_gettime(arg1, &ts));
         if (!is_error(ret)) {
-            host_to_target_timespec(arg2, &ts);
+            ret = host_to_target_timespec(arg2, &ts);
         }
         break;
     }
-- 
2.11.0

  parent reply	other threads:[~2018-04-02 17:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 17:13 [Qemu-devel] [PULL 0/8] xtensa-specific and generic fixes for linux-user Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 1/8] target/xtensa: fix flush_window_regs Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 2/8] target/xtensa: linux-user: rewind pc for restarted syscall Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 3/8] linux-user: call cpu_copy under clone_lock Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 4/8] linux-user: fix mq_getsetattr implementation Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 5/8] target/xtensa: linux-user: fix sysv IPC structures Max Filippov
2018-04-02 17:13 ` Max Filippov [this message]
2018-04-02 17:13 ` [Qemu-devel] [PULL 7/8] linux-user: implement clock_settime Max Filippov
2018-04-02 17:13 ` [Qemu-devel] [PULL 8/8] target/xtensa: linux-user: fix fadvise64 call Max Filippov
2018-04-03 22:23 ` [Qemu-devel] [PULL 0/8] xtensa-specific and generic fixes for linux-user Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402171354.27706-7-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).