From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f332R-0004QK-2A for qemu-devel@nongnu.org; Mon, 02 Apr 2018 13:14:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f332Q-0004fr-7L for qemu-devel@nongnu.org; Mon, 02 Apr 2018 13:14:35 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:40368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f332Q-0004fi-0h for qemu-devel@nongnu.org; Mon, 02 Apr 2018 13:14:34 -0400 Received: by mail-wr0-x242.google.com with SMTP id n2so11403831wrj.7 for ; Mon, 02 Apr 2018 10:14:33 -0700 (PDT) From: Max Filippov Date: Mon, 2 Apr 2018 10:13:52 -0700 Message-Id: <20180402171354.27706-7-jcmvbkbc@gmail.com> In-Reply-To: <20180402171354.27706-1-jcmvbkbc@gmail.com> References: <20180402171354.27706-1-jcmvbkbc@gmail.com> Subject: [Qemu-devel] [PULL 6/8] linux-user: fix error propagation in clock_gettime List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Max Filippov , Riku Voipio , Laurent Vivier host_to_target_timespec may return error if target address could not be locked, but it is ignored. Propagate return value of host_to_target_timespec to the caller of clock_gettime. Reviewed-by: Laurent Vivier Signed-off-by: Max Filippov --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d51e2a00ee31..52e2f9c16479 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -11884,7 +11884,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, struct timespec ts; ret = get_errno(clock_gettime(arg1, &ts)); if (!is_error(ret)) { - host_to_target_timespec(arg2, &ts); + ret = host_to_target_timespec(arg2, &ts); } break; } -- 2.11.0