From: "Richard W.M. Jones" <rjones@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, patches@groups.riscv.org, mjc@sifive.com,
palmer@sifive.com
Subject: Re: [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty
Date: Tue, 3 Apr 2018 08:46:27 +0100 [thread overview]
Message-ID: <20180403074627.GN2450@redhat.com> (raw)
In-Reply-To: <20180328022233.13400-1-richard.henderson@linaro.org>
On Wed, Mar 28, 2018 at 10:22:31AM +0800, Richard Henderson wrote:
> Since it was my patch that broke FP state tracking in the
> first place, I feel obligated to fix it again.
I missed this patch, thanks Michael Clark for pointing it out to me.
I've just tried it now using my test reproducer of the bug
(http://oirase.annexia.org/tmp/sched.c) and Fedora/RISC-V and it
appears to fix the problem.
> Mark mstatus[fs] as dirty whenever we write to the file.
> This can be optimized by only doing so once within a TB
> which initially began with a clean file.
>
> I have not yet put together an environment that can test
> this, so I'll need someone else to give it a go.
This is the Fedora stage4 disk image which works fine under qemu from
git (make sure you read the readme.txt file first):
https://fedorapeople.org/groups/risc-v/disk-images/
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
prev parent reply other threads:[~2018-04-03 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 2:22 [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty Richard Henderson
2018-03-28 2:22 ` [Qemu-devel] [PATCH 1/2] target/riscv: Split out mstatus_fs from tb_flags during translation Richard Henderson
2018-03-28 20:48 ` Michael Clark
2018-03-28 2:22 ` [Qemu-devel] [PATCH 2/2] target/riscv: Mark MSTATUS_FS dirty Richard Henderson
2018-03-28 4:58 ` Richard Henderson
2018-03-28 17:36 ` Michael Clark
2018-03-28 17:47 ` Michael Clark
2018-03-28 20:50 ` Michael Clark
2018-03-28 4:54 ` [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty Michael Clark
2018-03-28 17:58 ` Michael Clark
2018-04-03 7:46 ` Richard W.M. Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403074627.GN2450@redhat.com \
--to=rjones@redhat.com \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=patches@groups.riscv.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).