From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
jsnow@redhat.com, eblake@redhat.com, stefanha@redhat.com,
den@openvz.org
Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208
Date: Tue, 3 Apr 2018 15:36:32 +0200 [thread overview]
Message-ID: <20180403133632.GC11070@localhost.localdomain> (raw)
In-Reply-To: <1522422996-14235-4-git-send-email-vsementsov@virtuozzo.com>
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Blacklist these formats, as they don't support image creation, as they
> say:
> > ./qemu-img create -f bochs x 1m
> qemu-img: x: Format driver 'bochs' does not support image creation
>
> > ./qemu-img create -f cloop x 1m
> qemu-img: x: Format driver 'cloop' does not support image creation
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
We can take this for now, but I think I would actually prefer a solution
like in the bash tests, where the $IMGFMT_GENERIC environment variable
is checked for "_supported_fmt generic".
I suppose in Python test cases, we can assume that generic is meant when
neither supported_fmts nor unsupported_fmts are given (or both are empty
lists).
Kevin
next prev parent reply other threads:[~2018-04-03 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
2018-04-03 13:54 ` Kevin Wolf
2018-04-04 8:48 ` Vladimir Sementsov-Ogievskiy
2018-04-04 9:50 ` Kevin Wolf
2018-03-30 15:16 ` [Qemu-devel] [PATCH 2/3] iotests.py: support unsupported_fmts in main() Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-04-03 13:36 ` Kevin Wolf [this message]
2018-04-09 11:30 ` Vladimir Sementsov-Ogievskiy
2018-04-09 13:29 ` Kevin Wolf
2018-03-30 15:17 ` [Qemu-devel] [PATCH for 2.12 0/3] " Vladimir Sementsov-Ogievskiy
2018-03-31 8:29 ` [Qemu-devel] [PATCH " no-reply
2018-03-31 8:58 ` no-reply
2018-04-04 10:05 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403133632.GC11070@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).