From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3M7N-0005rF-V8 for qemu-devel@nongnu.org; Tue, 03 Apr 2018 09:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3M7K-0003gk-6h for qemu-devel@nongnu.org; Tue, 03 Apr 2018 09:36:57 -0400 Date: Tue, 3 Apr 2018 15:36:32 +0200 From: Kevin Wolf Message-ID: <20180403133632.GC11070@localhost.localdomain> References: <1522422996-14235-1-git-send-email-vsementsov@virtuozzo.com> <1522422996-14235-4-git-send-email-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522422996-14235-4-git-send-email-vsementsov@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com, jsnow@redhat.com, eblake@redhat.com, stefanha@redhat.com, den@openvz.org Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > Blacklist these formats, as they don't support image creation, as they > say: > > ./qemu-img create -f bochs x 1m > qemu-img: x: Format driver 'bochs' does not support image creation > > > ./qemu-img create -f cloop x 1m > qemu-img: x: Format driver 'cloop' does not support image creation > > Signed-off-by: Vladimir Sementsov-Ogievskiy We can take this for now, but I think I would actually prefer a solution like in the bash tests, where the $IMGFMT_GENERIC environment variable is checked for "_supported_fmt generic". I suppose in Python test cases, we can assume that generic is meant when neither supported_fmts nor unsupported_fmts are given (or both are empty lists). Kevin