From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3MV1-0002YR-E8 for qemu-devel@nongnu.org; Tue, 03 Apr 2018 10:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3MUt-0004CE-T8 for qemu-devel@nongnu.org; Tue, 03 Apr 2018 10:01:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43382) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f3MUt-0004BE-OG for qemu-devel@nongnu.org; Tue, 03 Apr 2018 10:01:15 -0400 From: Eduardo Habkost Date: Tue, 3 Apr 2018 11:01:06 -0300 Message-Id: <20180403140107.26125-2-ehabkost@redhat.com> In-Reply-To: <20180403140107.26125-1-ehabkost@redhat.com> References: <20180403140107.26125-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 1/2] exec: fix memory leak in find_max_supported_pagesize() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , qemu-devel@nongnu.org, Richard Henderson , Greg Kurz From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. Signed-off-by: Greg Kurz Message-Id: <152231458624.69730.1752893648612848392.stgit@bahia.lan> Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Eduardo Habkost --- exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index c09bd93df3..02b1efebb7 100644 --- a/exec.c +++ b/exec.c @@ -1495,6 +1495,7 @@ static int find_max_supported_pagesize(Object *obj, void *opaque) mem_path = object_property_get_str(obj, "mem-path", NULL); if (mem_path) { long hpsize = qemu_mempath_getpagesize(mem_path); + g_free(mem_path); if (hpsize < *hpsize_min) { *hpsize_min = hpsize; } -- 2.14.3