qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	pbonzini@redhat.com, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code
Date: Wed, 4 Apr 2018 17:07:56 +0800	[thread overview]
Message-ID: <20180404090756.GJ12052@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180404082331.GD3186@redhat.com>

On Wed, 04/04 09:23, Daniel P. Berrangé wrote:
> On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote:
> > ./configure and make now take care of submodules, we only need to clone
> > the top tree.
> 
> If you don't include the submodules in the tar.gz archive, then the
> test system needs to be able to clone them from qemu.org, which
> requires networking.
> 
> The VM tests have networking by default, but the docker tests do
> not have networking - you need to opt-in by setting NETWORK=1
> make variable. So AFAICT, this will break docker tests.

Yes, I'll revise the patch.

Fam

  reply	other threads:[~2018-04-04  9:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  2:51 [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests Fam Zheng
2018-04-04  2:51 ` [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code Fam Zheng
2018-04-04  8:23   ` Daniel P. Berrangé
2018-04-04  9:07     ` Fam Zheng [this message]
2018-04-04  9:24       ` Daniel P. Berrangé
2018-04-04  9:37         ` Fam Zheng
2018-04-04  2:52 ` [Qemu-devel] [PATCH 2/3] tests: Add an option for snapshot (default: off) Fam Zheng
2018-04-04  2:52 ` [Qemu-devel] [PATCH 3/3] tests: Add centos VM testing Fam Zheng
2018-04-04  3:01 ` [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests no-reply
2018-04-04  3:04 ` no-reply
2018-04-04  5:03 ` Peter Xu
2018-04-04  6:56   ` Peter Xu
2018-04-04  8:19 ` Daniel P. Berrangé
2018-04-04  8:24   ` Fam Zheng
2018-04-06 16:47 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180404090756.GJ12052@lemon.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).