From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3eOi-0001kS-Sg for qemu-devel@nongnu.org; Wed, 04 Apr 2018 05:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3eOd-0001nx-2p for qemu-devel@nongnu.org; Wed, 04 Apr 2018 05:08:04 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58538 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f3eOc-0001nr-UH for qemu-devel@nongnu.org; Wed, 04 Apr 2018 05:07:59 -0400 Date: Wed, 4 Apr 2018 17:07:56 +0800 From: Fam Zheng Message-ID: <20180404090756.GJ12052@lemon.usersys.redhat.com> References: <20180404025201.11921-1-famz@redhat.com> <20180404025201.11921-2-famz@redhat.com> <20180404082331.GD3186@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180404082331.GD3186@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Drop submodule code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: qemu-devel@nongnu.org, Alex =?iso-8859-1?Q?Benn=E9e?= , pbonzini@redhat.com, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= On Wed, 04/04 09:23, Daniel P. Berrang=E9 wrote: > On Wed, Apr 04, 2018 at 10:51:59AM +0800, Fam Zheng wrote: > > ./configure and make now take care of submodules, we only need to clo= ne > > the top tree. >=20 > If you don't include the submodules in the tar.gz archive, then the > test system needs to be able to clone them from qemu.org, which > requires networking. >=20 > The VM tests have networking by default, but the docker tests do > not have networking - you need to opt-in by setting NETWORK=3D1 > make variable. So AFAICT, this will break docker tests. Yes, I'll revise the patch. Fam