From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com,
wangxinxin.wang@huawei.com, linzhecheng <linzhecheng@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] virtio-serial: fix heap-over-flow
Date: Wed, 4 Apr 2018 17:22:07 +0300 [thread overview]
Message-ID: <20180404172155-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180404095322.GK4467@stefanha-x1.localdomain>
On Wed, Apr 04, 2018 at 10:53:22AM +0100, Stefan Hajnoczi wrote:
> On Wed, Mar 28, 2018 at 09:34:35PM +0800, linzhecheng wrote:
> > Check device having the feature of VIRTIO_CONSOLE_F_EMERG_WRITE before
> > get config->emerg_wr. It is neccessary because sizeof(virtio_console_config)
> > is 8 byte if VirtIOSerial doesn't have the feature of
> > VIRTIO_CONSOLE_F_EMERG_WRITE(see virtio_serial_device_realize),
> > read/write emerg_wr will lead to heap-over-flow.
> >
> > Signed-off-by: linzhecheng <linzhecheng@huawei.com>
>
> Michael or Paolo: Please merge for QEMU 2.12
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Will merge.
prev parent reply other threads:[~2018-04-04 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 13:34 [Qemu-devel] [PATCH v2] virtio-serial: fix heap-over-flow linzhecheng
2018-04-04 9:53 ` Stefan Hajnoczi
2018-04-04 14:22 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404172155-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=linzhecheng@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=wangxinxin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).