From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 02/16] qht: return existing entry when qht_insert fails
Date: Thu, 5 Apr 2018 13:10:54 -0400 [thread overview]
Message-ID: <20180405171054.GA15681@flamenco> (raw)
In-Reply-To: <87605g88je.fsf@linaro.org>
On Wed, Mar 28, 2018 at 17:33:09 +0100, Alex Bennée wrote:
> Emilio G. Cota <cota@braap.org> writes:
> > -bool qht_insert(struct qht *ht, void *p, uint32_t hash);
> > +void *qht_insert(struct qht *ht, void *p, uint32_t hash);
>
> Hmm this seems needlessly counter intuitive. I realise the potential
> efficiency in overloading success/fail but wouldn't a:
>
> bool qht_insert(struct qht *ht, void *p, uint32_t hash, void **existing);
>
> be conceptually nicer?
Good point, fixed in v2.
Thanks,
E.
next prev parent reply other threads:[~2018-04-05 17:11 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 5:39 [Qemu-devel] [PATCH 00/16] tcg: tb_lock removal redux v1 Emilio G. Cota
2018-02-27 5:39 ` [Qemu-devel] [PATCH 01/16] qht: require a default comparison function Emilio G. Cota
2018-02-28 19:02 ` Richard Henderson
2018-03-28 16:21 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 02/16] qht: return existing entry when qht_insert fails Emilio G. Cota
2018-02-28 19:10 ` Richard Henderson
2018-03-28 16:33 ` Alex Bennée
2018-04-05 17:10 ` Emilio G. Cota [this message]
2018-02-27 5:39 ` [Qemu-devel] [PATCH 03/16] tcg: track TBs with per-region BST's Emilio G. Cota
2018-02-28 20:53 ` Richard Henderson
2018-03-29 9:54 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 04/16] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx Emilio G. Cota
2018-02-28 20:55 ` Richard Henderson
2018-03-29 10:06 ` Alex Bennée
2018-04-05 17:18 ` Emilio G. Cota
2018-02-27 5:39 ` [Qemu-devel] [PATCH 05/16] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB Emilio G. Cota
2018-02-28 21:40 ` Richard Henderson
2018-02-28 22:50 ` Emilio G. Cota
2018-02-28 22:53 ` Richard Henderson
2018-02-27 5:39 ` [Qemu-devel] [PATCH 06/16] translate-all: make l1_map lockless Emilio G. Cota
2018-02-28 22:15 ` Richard Henderson
2018-03-29 10:16 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 07/16] translate-all: remove hole in PageDesc Emilio G. Cota
2018-02-28 22:17 ` Richard Henderson
2018-03-29 10:17 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 08/16] translate-all: work page-by-page in tb_invalidate_phys_range_1 Emilio G. Cota
2018-02-28 22:23 ` Richard Henderson
2018-03-29 10:10 ` Alex Bennée
2018-03-29 10:17 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 09/16] translate-all: move tb_invalidate_phys_page_range up in the file Emilio G. Cota
2018-02-28 22:24 ` Richard Henderson
2018-03-29 10:08 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 10/16] translate-all: use per-page locking in !user-mode Emilio G. Cota
2018-03-29 14:55 ` Alex Bennée
2018-04-06 0:43 ` Emilio G. Cota
2018-02-27 5:39 ` [Qemu-devel] [PATCH 11/16] translate-all: add page_collection assertions Emilio G. Cota
2018-03-29 15:08 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 12/16] translate-all: discard TB when tb_link_page returns an existing matching TB Emilio G. Cota
2018-03-29 15:19 ` Alex Bennée
2018-04-06 1:23 ` Emilio G. Cota
2018-02-27 5:39 ` [Qemu-devel] [PATCH 13/16] translate-all: protect TB jumps with a per-destination-TB lock Emilio G. Cota
2018-02-27 11:33 ` Paolo Bonzini
2018-02-27 11:43 ` Laurent Desnogues
2018-02-27 14:31 ` Paolo Bonzini
2018-03-28 15:57 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 14/16] cputlb: remove tb_lock from tlb_flush functions Emilio G. Cota
2018-03-29 15:46 ` Alex Bennée
2018-02-27 5:39 ` [Qemu-devel] [PATCH 15/16] translate-all: remove tb_lock mention from cpu_restore_state_from_tb Emilio G. Cota
2018-03-29 16:06 ` Alex Bennée
2018-04-06 1:40 ` Emilio G. Cota
2018-02-27 5:39 ` [Qemu-devel] [PATCH 16/16] tcg: remove tb_lock Emilio G. Cota
2018-03-29 16:15 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405171054.GA15681@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).