[Qemu-devel] [PULL for-2.12 0/1] tcg vector fix

[Qemu-devel] [PULL for-2.12 0/1] tcg vector fix

[Richard Henderson]

Fixes the reported problem w/ ppc64 host (gcc 4.8.5) + aa64 guest.


r~


The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d:

  Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100)

are available in the Git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20180407

for you to fetch changes up to 6cb1d3b8517572031a22675280ec642972cdb395:

  tcg: Fix out-of-line generic vector compares (2018-04-06 23:08:50 +1000)

----------------------------------------------------------------
Fix generic host vector compares.

----------------------------------------------------------------
Richard Henderson (1):
      tcg: Fix out-of-line generic vector compares

 accel/tcg/tcg-runtime-gvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL for-2.12 1/1] tcg: Fix out-of-line generic vector compares

[Richard Henderson]

A mistake in the type passed to sizeof, that happens to work
when the out-of-line fallback itself is using host vectors,
but fails when using only the base types.

Tested-by: Emilio G. Cota <cota@braap.org>
Reported-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 accel/tcg/tcg-runtime-gvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
index 8bf8d63912..90340e56e0 100644
--- a/accel/tcg/tcg-runtime-gvec.c
+++ b/accel/tcg/tcg-runtime-gvec.c
@@ -705,7 +705,7 @@ void HELPER(NAME)(void *d, void *a, void *b, uint32_t desc)                \
 {                                                                          \
     intptr_t oprsz = simd_oprsz(desc);                                     \
     intptr_t i;                                                            \
-    for (i = 0; i < oprsz; i += sizeof(vec64)) {                           \
+    for (i = 0; i < oprsz; i += sizeof(TYPE)) {                            \
         *(TYPE *)(d + i) = DO_CMP0(*(TYPE *)(a + i) OP *(TYPE *)(b + i));  \
     }                                                                      \
     clear_high(d, oprsz, desc);                                            \
-- 
2.14.3

Re: [Qemu-devel] [PULL for-2.12 0/1] tcg vector fix

[Peter Maydell]

On 6 April 2018 at 14:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
> Fixes the reported problem w/ ppc64 host (gcc 4.8.5) + aa64 guest.
>
>
> r~
>
>
> The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d:
>
>   Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-tcg-20180407
>
> for you to fetch changes up to 6cb1d3b8517572031a22675280ec642972cdb395:
>
>   tcg: Fix out-of-line generic vector compares (2018-04-06 23:08:50 +1000)
>
> ----------------------------------------------------------------
> Fix generic host vector compares.
>
> ----------------------------------------------------------------
> Richard Henderson (1):
>       tcg: Fix out-of-line generic vector compares
>
>  accel/tcg/tcg-runtime-gvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- PMM