From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed()
Date: Mon, 9 Apr 2018 15:05:39 +0800 [thread overview]
Message-ID: <20180409070539.GF4848@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180408030542.17855-1-peterx@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Sun, Apr 08, 2018 at 11:05:42AM +0800, Peter Xu wrote:
> If there are more than one events, wait_until_completed() might return
> the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop
> will continue to run even if completed is set to True.
>
> It never happened before, but it can be triggered when OOB is enabled
> due to the RESUME startup message. Fix that up.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-04-09 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 3:05 [Qemu-devel] [PATCH v2] iotests: fix wait_until_completed() Peter Xu
2018-04-08 9:03 ` Fam Zheng
2018-04-09 7:05 ` Stefan Hajnoczi [this message]
2018-04-09 14:06 ` Eric Blake
2018-04-10 6:26 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409070539.GF4848@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).