From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5WrY-0007JW-VT for qemu-devel@nongnu.org; Mon, 09 Apr 2018 09:29:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5WrY-0007aW-0Q for qemu-devel@nongnu.org; Mon, 09 Apr 2018 09:29:36 -0400 Date: Mon, 9 Apr 2018 15:29:27 +0200 From: Kevin Wolf Message-ID: <20180409132927.GF5294@localhost.localdomain> References: <1522422996-14235-1-git-send-email-vsementsov@virtuozzo.com> <1522422996-14235-4-git-send-email-vsementsov@virtuozzo.com> <20180403133632.GC11070@localhost.localdomain> <92a757db-fa28-04ca-cd95-999b4cd5e1b0@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92a757db-fa28-04ca-cd95-999b4cd5e1b0@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com, jsnow@redhat.com, eblake@redhat.com, stefanha@redhat.com, den@openvz.org Am 09.04.2018 um 13:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.04.2018 16:36, Kevin Wolf wrote: > > Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Blacklist these formats, as they don't support image creation, as they > > > say: > > > > ./qemu-img create -f bochs x 1m > > > qemu-img: x: Format driver 'bochs' does not support image creation > > > > > > > ./qemu-img create -f cloop x 1m > > > qemu-img: x: Format driver 'cloop' does not support image creation > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > We can take this for now, but I think I would actually prefer a solution > > like in the bash tests, where the $IMGFMT_GENERIC environment variable > > is checked for "_supported_fmt generic". > > > > I suppose in Python test cases, we can assume that generic is meant when > > neither supported_fmts nor unsupported_fmts are given (or both are empty > > lists). > > > > Kevin > > it may be ok for verify_image_format, as we can call it or not call (to > support all formats). > > but iotests main function always call verify_image_format, so, this > will skip bochs and cloop for all iotests which call maind() without > format restriction. Yes, but that's what we want. Read-only formats can only be tested with test cases made specifically for the respective format, because they need to use a binary image from sample_images/. I don't think there is a case where we really want to run the test for all possible formats. Can you think of one? > So, I think it is safer to directly mimic bash tests behavior - allow > 'generic' as a member of supported_fmts. That works, too, but I think it's not quite as nice. Kevin