From: Peter Xu <peterx@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled
Date: Tue, 10 Apr 2018 19:14:22 +0800 [thread overview]
Message-ID: <20180410111422.GG27604@xz-mi> (raw)
In-Reply-To: <20180410084950.GB2785@lemon.usersys.redhat.com>
On Tue, Apr 10, 2018 at 04:49:50PM +0800, Fam Zheng wrote:
[...]
> We have had
>
> function_name()
> {
> ...
>
> and
>
> function_name() {
> ...
>
> and
>
> function_name () {
> ...
>
> finally you invent the last in the family:
>
> function_name ()
> {
>
> :)
I was careful about whether we were using the "function" keyword, but
still that seems to be not enough... :-)
[...]
> Reviewed-by: Fam Zheng <famz@redhat.com>
Thanks!
--
Peter Xu
prev parent reply other threads:[~2018-04-10 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 5:40 [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled Peter Xu
2018-04-10 8:48 ` Daniel P. Berrangé
2018-04-10 8:49 ` Fam Zheng
2018-04-10 11:14 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410111422.GG27604@xz-mi \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).