[Qemu-devel] [PULL 0/1] migration queue

[Qemu-devel] [PULL 0/1] migration queue

[Dr. David Alan Gilbert (git)]

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8:

  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' into staging (2018-04-10 14:04:27 +0100)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-migration-20180410a

for you to fetch changes up to a18a73d7472e6ff5bc1e5f7fb9f7a42464295d03:

  Revert "migration: Don't activate block devices if using -S" (2018-04-10 15:28:42 +0100)

----------------------------------------------------------------
Migration reversion pull for 2.12

One to revert after we decided it needs some more thinking.

----------------------------------------------------------------
Dr. David Alan Gilbert (1):
      Revert "migration: Don't activate block devices if using -S"

 migration/migration.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

[Qemu-devel] [PULL 1/1] Revert "migration: Don't activate block devices if using -S"

[Dr. David Alan Gilbert (git)]

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

This reverts commit 0746a92612276aee69e66dfe6782b0f882d221d5.
Discussion with kwolf suggests this is actually an API change that
we need to gate on a capability.  Push to 2.13.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/migration.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 58bd382730..52a5092add 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -306,21 +306,13 @@ static void process_incoming_migration_bh(void *opaque)
     Error *local_err = NULL;
     MigrationIncomingState *mis = opaque;
 
-    /* Only fire up the block code now if we're going to restart the
-     * VM, else 'cont' will do it.
-     * This causes file locking to happen; so we don't want it to happen
-     * unless we really are starting the VM.
-     */
-    if (autostart && (!global_state_received() ||
-        global_state_get_runstate() == RUN_STATE_RUNNING)) {
-        /* Make sure all file formats flush their mutable metadata.
-         * If we get an error here, just don't restart the VM yet. */
-        bdrv_invalidate_cache_all(&local_err);
-        if (local_err) {
-            error_report_err(local_err);
-            local_err = NULL;
-            autostart = false;
-        }
+    /* Make sure all file formats flush their mutable metadata.
+     * If we get an error here, just don't restart the VM yet. */
+    bdrv_invalidate_cache_all(&local_err);
+    if (local_err) {
+        error_report_err(local_err);
+        local_err = NULL;
+        autostart = false;
     }
 
     /*
-- 
2.16.2

Re: [Qemu-devel] [PULL 0/1] migration queue

[Peter Maydell]

On 10 April 2018 at 16:03, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' into staging (2018-04-10 14:04:27 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-migration-20180410a
>
> for you to fetch changes up to a18a73d7472e6ff5bc1e5f7fb9f7a42464295d03:
>
>   Revert "migration: Don't activate block devices if using -S" (2018-04-10 15:28:42 +0100)
>
> ----------------------------------------------------------------
> Migration reversion pull for 2.12
>
> One to revert after we decided it needs some more thinking.
>
> ----------------------------------------------------------------
> Dr. David Alan Gilbert (1):
>       Revert "migration: Don't activate block devices if using -S"
>
>  migration/migration.c | 22 +++++++---------------
>  1 file changed, 7 insertions(+), 15 deletions(-)
>

Applied, thanks.

-- PMM