qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 6/7] commit/stream: Reset delay_ns
Date: Tue, 10 Apr 2018 17:37:47 +0200	[thread overview]
Message-ID: <20180410153748.22505-7-kwolf@redhat.com> (raw)
In-Reply-To: <20180410153748.22505-1-kwolf@redhat.com>

Streaming and the commit block job only want to apply throttling when
they actually copied data instead of skipping it, so they made the
calculation of delay_ns conditional. However, delay_ns isn't reset when
skipping some sectors, so instead of not waiting, the old delay is
applied again.

Properly reset delay_ns where needed.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 block/commit.c | 2 ++
 block/stream.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/block/commit.c b/block/commit.c
index ab4fa3c3cf..1432baeef4 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -202,6 +202,8 @@ static void coroutine_fn commit_run(void *opaque)
 
         if (copy && s->common.speed) {
             delay_ns = ratelimit_calculate_delay(&s->limit, n);
+        } else {
+            delay_ns = 0;
         }
     }
 
diff --git a/block/stream.c b/block/stream.c
index f3b53f49e2..1a85708fcf 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -188,6 +188,8 @@ static void coroutine_fn stream_run(void *opaque)
         s->common.offset += n;
         if (copy && s->common.speed) {
             delay_ns = ratelimit_calculate_delay(&s->limit, n);
+        } else {
+            delay_ns = 0;
         }
     }
 
-- 
2.13.6

  parent reply	other threads:[~2018-04-10 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 15:37 [Qemu-devel] [PULL 0/7] Block layer patches for 2.12.0-rc3 Kevin Wolf
2018-04-10 15:37 ` [Qemu-devel] [PULL 1/7] iotests.py: support unsupported_fmts in main() Kevin Wolf
2018-04-10 15:37 ` [Qemu-devel] [PULL 2/7] hw/block/pflash_cfi: fix off-by-one error Kevin Wolf
2018-04-10 15:37 ` [Qemu-devel] [PULL 3/7] iotests.py: improve verify_image_format helper Kevin Wolf
2018-04-10 15:37 ` [Qemu-devel] [PULL 4/7] iotests: blacklist bochs and cloop for 205 and 208 Kevin Wolf
2018-04-10 15:37 ` [Qemu-devel] [PULL 5/7] qemu-iotests: Remove _supported_fmt dmg Kevin Wolf
2018-04-10 15:37 ` Kevin Wolf [this message]
2018-04-10 15:37 ` [Qemu-devel] [PULL 7/7] qemu-iotests: update 185 output Kevin Wolf
2018-04-11 10:21 ` [Qemu-devel] [PULL 0/7] Block layer patches for 2.12.0-rc3 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410153748.22505-7-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).