From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6acB-0007eS-Ei for qemu-devel@nongnu.org; Thu, 12 Apr 2018 07:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6ac8-0002uy-Aq for qemu-devel@nongnu.org; Thu, 12 Apr 2018 07:42:07 -0400 Date: Thu, 12 Apr 2018 13:41:53 +0200 From: Cornelia Huck Message-ID: <20180412134153.5cebdec6.cohuck@redhat.com> In-Reply-To: <20180412093521.2469-1-david@redhat.com> References: <20180412093521.2469-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Richard Henderson , Alexander Graf , Christian Borntraeger , Thomas Huth On Thu, 12 Apr 2018 11:35:21 +0200 David Hildenbrand wrote: > We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). > > Let's remove the ones that are no longer needed. > > Remaining places (for s390x) are in > - target/s390x/sigp.c, on the target CPU > - target/s390x/cpu.c:s390_cpu_get_crash_info() > > While at it, use kvm_cpu_synchronize_state() instead of > cpu_synchronize_state() in KVM code. (suggested by Thomas Huth) > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-pci-inst.c | 8 -------- > target/s390x/kvm.c | 20 +------------------- > 2 files changed, 1 insertion(+), 27 deletions(-) Nice :) Will apply to s390-next, but would not mind some r-bs.