From: Igor Mammedov <imammedo@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Eric Auger <eric.auger@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.13 1/4] arm: reuse arm_boot_address_space() in armv7m_load_kernel()
Date: Fri, 13 Apr 2018 15:41:00 +0200 [thread overview]
Message-ID: <20180413154100.1731a448@redhat.com> (raw)
In-Reply-To: <CAFEAcA9LVUfmHGor=OmnXf0Dhj5zP_e++WELKwtx0Ru7VcRA-g@mail.gmail.com>
On Thu, 12 Apr 2018 19:22:13 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 12 April 2018 at 17:40, Igor Mammedov <imammedo@redhat.com> wrote:
> > reduce code duplication by resusing arm_boot_address_space()
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > include/hw/arm/arm.h | 2 ++
> > hw/arm/armv7m.c | 10 +---------
> > hw/arm/boot.c | 16 ++++++++--------
> > 3 files changed, 11 insertions(+), 17 deletions(-)
>
> This minor duplication was deliberate, because hw/arm/armv7m.c
> is for M profile cores only, and hw/arm/boot.c is for
> A/R profile cores only. I don't think that saving a
> single if/else in armv7m.c really justifies blurring
> that dividing line.
I'll drop patch on respin
> thanks
> -- PMM
next prev parent reply other threads:[~2018-04-13 13:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 16:40 [Qemu-devel] [PATCH for-2.13 0/4] arm: isolate and clean up dtb generation Igor Mammedov
2018-04-12 16:40 ` [Qemu-devel] [PATCH for-2.13 1/4] arm: reuse arm_boot_address_space() in armv7m_load_kernel() Igor Mammedov
2018-04-12 18:22 ` Peter Maydell
2018-04-13 13:41 ` Igor Mammedov [this message]
2018-04-12 16:40 ` [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier Igor Mammedov
2018-04-13 18:00 ` Auger Eric
2018-04-16 8:00 ` Igor Mammedov
2018-04-16 2:43 ` David Gibson
2018-04-16 8:19 ` Igor Mammedov
2018-04-17 1:15 ` David Gibson
2018-04-17 16:34 ` [Qemu-devel] [PATCH] ppc: e500: switch E500 based machines to full machine definition Igor Mammedov
2018-04-18 9:38 ` David Gibson
2018-04-16 17:25 ` [Qemu-devel] [PATCH for-2.13 2/4] platform-bus-device: use device plug callback instead of machine_done notifier Peter Maydell
2018-04-12 16:40 ` [Qemu-devel] [PATCH for-2.13 3/4] arm: always start from first_cpu when registering loader cpu reset callback Igor Mammedov
2018-04-12 18:29 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-04-13 13:59 ` Igor Mammedov
2018-04-16 17:17 ` Peter Maydell
2018-04-17 11:35 ` Igor Mammedov
2018-04-12 16:40 ` [Qemu-devel] [PATCH for-2.13 4/4] arm/boot: split load_dtb() from arm_load_kernel() Igor Mammedov
2018-04-16 17:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413154100.1731a448@redhat.com \
--to=imammedo@redhat.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).