qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, den@openvz.org,
	vsementsov@virtuozzo.com, pbonzini@redhat.com, eblake@redhat.com,
	armbru@redhat.com, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] NBD export bitmaps
Date: Fri, 13 Apr 2018 21:13:58 +0300	[thread overview]
Message-ID: <20180413181401.46318-1-vsementsov@virtuozzo.com> (raw)

Hi all.

This is a proposal and realization of new NBD meta context:
qemu. (I hope to send corresponding proposal to NBD protocol soon)

New possible queries will look like:
qemu:dirty-bitmap:<export-bitmap-name>

Mapping from export-bitmap-name to BdrvDirtyBitmap is done through qmp
command nbd-server-add-bitmap. For now, only one bitmap export is
allowed per NBD export, however it may be easily improved if needed 
(we don't have such cases for now)

Client and testing.
I wrote client code for Virtuozzo, but it turned out to be unused,
actually it's used only for tests. We don't have cases, where we need
to import dirty bitmap through qemu nbd-client. All this done for
exporting dirty bitmaps to the third tool. So, I think, it is not worth
refactoring, rebasing and merging client part upstream, if there are no
real usage cases.

v2:
01 from v1 is dropped: actually, we don't need generic namespace
parsing for now (especially, after moving to qemu: namespace, which has
the same length as base:), lets postpone it.

01: Improve comment wording (Eric), add Eric's r-b
02: improve commit message
    move NBD_STATE_DIRTY to header
    add comment on NBD_MAX_BITMAP_EXTENTS
    remove MAX_EXTENT_LENGTH and instead update add_extents() which
      uses it
    use export_bitmap_context instead of export_bitmap_name to reduce
      operations on it
    move from qemu-dirty-bitmap to qemu:dirty-bitmap
    other way to parse namespace name
    handle FLAG_DF
03: Improve specification of new qmp command (Eric)

Vladimir Sementsov-Ogievskiy (3):
  nbd/server: add nbd_meta_single_query helper
  nbd/server: implement dirty bitmap export
  qapi: new qmp command nbd-server-add-bitmap

 qapi/block.json     |  23 +++++
 include/block/nbd.h |   6 ++
 blockdev-nbd.c      |  23 +++++
 nbd/server.c        | 274 ++++++++++++++++++++++++++++++++++++++++++++++------
 4 files changed, 297 insertions(+), 29 deletions(-)

-- 
2.11.1

             reply	other threads:[~2018-04-13 18:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 18:13 Vladimir Sementsov-Ogievskiy [this message]
2018-04-13 18:13 ` [Qemu-devel] [PATCH v2 1/3] nbd/server: add nbd_meta_single_query helper Vladimir Sementsov-Ogievskiy
2018-04-13 18:14 ` [Qemu-devel] [PATCH v2 2/3] nbd/server: implement dirty bitmap export Vladimir Sementsov-Ogievskiy
2018-04-18 14:05   ` Eric Blake
2018-04-19  8:31     ` Vladimir Sementsov-Ogievskiy
2018-04-13 18:14 ` [Qemu-devel] [PATCH v2 3/3] qapi: new qmp command nbd-server-add-bitmap Vladimir Sementsov-Ogievskiy
2018-04-30 21:22 ` [Qemu-devel] [PATCH v2 0/3] NBD export bitmaps Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413181401.46318-1-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).