qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-trivial@nongnu.org, Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 07/41] hw/ivshmem: Use the BYTE-based definitions
Date: Sun, 15 Apr 2018 20:42:33 -0300	[thread overview]
Message-ID: <20180415234307.28132-8-f4bug@amsat.org> (raw)
In-Reply-To: <20180415234307.28132-1-f4bug@amsat.org>

It eases code review, unit is explicit.

Patch generated using:

  $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/

and modified manually.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/misc/ivshmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 16f03701b7..2f4715abad 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -17,6 +17,7 @@
  * GNU GPL, version 2 or (at your option) any later version.
  */
 #include "qemu/osdep.h"
+#include "qemu/units.h"
 #include "qapi/error.h"
 #include "qemu/cutils.h"
 #include "hw/hw.h"
@@ -1302,7 +1303,7 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
     }
 
     if (s->sizearg == NULL) {
-        s->legacy_size = 4 << 20; /* 4 MB default */
+        s->legacy_size = 4 * M_BYTE; /* 4 MB default */
     } else {
         int ret;
         uint64_t size;
-- 
2.17.0

  parent reply	other threads:[~2018-04-15 23:43 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-15 23:42 [Qemu-devel] [PATCH v3 00/41] hw: Use the BYTE-based definitions when useful Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes Philippe Mathieu-Daudé
2018-04-16  4:53   ` Thomas Huth
2018-04-16 10:06     ` Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 02/41] hw: Do not include "sysemu/block-backend.h" if it is not necessary Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 03/41] hw/block/nvme: Include the "qemu/cutils.h" in the source file Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 04/41] hw/misc/mips_itu: Sort includes Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 05/41] hw/mips/r4k: Constify params_size Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 06/41] cutils: Extract byte-based definitions into a new header: "qemu/units.h" Philippe Mathieu-Daudé
2018-04-15 23:42 ` Philippe Mathieu-Daudé [this message]
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 08/41] hw/ipack: Use the BYTE-based definitions Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 09/41] hw/scsi: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 10/41] hw/smbios: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 11/41] hw/xen: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 12/41] hw/tpm: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 13/41] hw/block: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 15/41] hw/misc: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 16/41] hw/riscv: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 17/41] hw/m68k: " Philippe Mathieu-Daudé
2018-04-16  4:58   ` Thomas Huth
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 18/41] hw/sparc: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 19/41] hw/s390x: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 20/41] hw/hppa: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 21/41] hw/xtensa: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 22/41] hw/alpha: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 23/41] hw/tricore: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 24/41] hw/microblaze: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 25/41] hw/nios2: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 26/41] hw/cris: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 27/41] hw/lm32: " Philippe Mathieu-Daudé
2018-04-16  6:40   ` Michael Walle
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 28/41] hw/sh4: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 29/41] hw/mips: " Philippe Mathieu-Daudé
2018-04-16 20:56   ` Alistair Francis
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 30/41] hw/arm: " Philippe Mathieu-Daudé
2018-04-15 23:42 ` [Qemu-devel] [PATCH v3 33/41] hw/net: " Philippe Mathieu-Daudé
2018-04-16  5:23   ` Stefan Weil
2018-04-17 16:09     ` Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 34/41] hw/usb: " Philippe Mathieu-Daudé
2018-04-16  8:03   ` Gerd Hoffmann
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 35/41] hw/sd: " Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 36/41] hw/vfio: " Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 37/41] hw/virtio: " Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 38/41] hw/rdma: " Philippe Mathieu-Daudé
2018-04-16  4:23   ` Marcel Apfelbaum
2018-04-21 17:55   ` Yuval Shaia
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 39/41] hw/nvdimm: " Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 40/41] hw/loader: " Philippe Mathieu-Daudé
2018-04-15 23:43 ` [Qemu-devel] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly Philippe Mathieu-Daudé
2018-04-16  9:53   ` Marcel Apfelbaum
     [not found] ` <20180415234307.28132-33-f4bug@amsat.org>
2018-04-16  9:52   ` [Qemu-devel] [PATCH v3 32/41] hw/i386: Use the BYTE-based definitions Marcel Apfelbaum
     [not found] ` <20180415234307.28132-15-f4bug@amsat.org>
2018-04-16 20:58   ` [Qemu-devel] [Xen-devel] [PATCH v3 14/41] hw/display: " Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180415234307.28132-8-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).