From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits
Date: Mon, 16 Apr 2018 14:46:14 -0300 [thread overview]
Message-ID: <20180416174614.GB23840@localhost.localdomain> (raw)
In-Reply-To: <20180416174252.GA23840@localhost.localdomain>
On Mon, Apr 16, 2018 at 02:42:52PM -0300, Eduardo Habkost wrote:
> On Mon, Apr 16, 2018 at 05:57:35PM +0100, Peter Maydell wrote:
> > On 16 April 2018 at 17:39, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > > Last remaining fix for -rc4.
> > >
> > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515:
> > >
> > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' into staging (2018-04-16 15:30:54 +0100)
> > >
> > > are available in the Git repository at:
> > >
> > > git://github.com/ehabkost/qemu.git tags/x86-next-pull-request
> > >
> > > for you to fetch changes up to 0d914f39a77954bf5472b16130aeefe573a068f5:
> > >
> > > i386: Don't automatically enable FEAT_KVM_HINTS bits (2018-04-16 13:36:52 -0300)
> > >
> > > ----------------------------------------------------------------
> > > i386: Don't automatically enable FEAT_KVM_HINTS bits
> > >
> > > Bug fix for "-cpu host" with newer kernels.
> > >
> > > ----------------------------------------------------------------
> >
> > Is this a regression since 2.11 ?
>
> Yes.
For reference, it was introduced by:
commit be7773268d98176489483a315d3e2323cb0615b9
Author: Wanpeng Li <wanpengli@tencent.com>
Date: Fri Feb 9 06:15:25 2018 -0800
target-i386: add KVM_HINTS_DEDICATED performance hint
Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit
to determine if they run on dedicated vCPUs, allowing optimizations such
as usage of qspinlocks.
Sorry for not including a "Fixes:" tag in the commit message. If
you think it's worth it, I can redo the pull request with it.
--
Eduardo
next prev parent reply other threads:[~2018-04-16 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 16:39 [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits Eduardo Habkost
2018-04-16 16:39 ` [Qemu-devel] [PULL 1/1] " Eduardo Habkost
2018-04-16 16:57 ` [Qemu-devel] [PULL 0/1] " Peter Maydell
2018-04-16 17:42 ` Eduardo Habkost
2018-04-16 17:46 ` Eduardo Habkost [this message]
2018-04-16 17:49 ` Peter Maydell
2018-04-17 11:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416174614.GB23840@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).