qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Eric Blake" <eblake@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 for-2.13 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files
Date: Tue, 17 Apr 2018 15:22:01 +0800	[thread overview]
Message-ID: <20180417072201.GK10770@stefanha-x1.localdomain> (raw)
In-Reply-To: <1523861081-3600-3-git-send-email-thuth@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Mon, Apr 16, 2018 at 08:44:40AM +0200, Thomas Huth wrote:
> 'vlan' is very confusing since it does not mean something like IEEE
> 802.1Q, but rather emulated hubs, so let's switch to that terminology
> instead.
> 
> Buglink: https://bugs.launchpad.net/qemu/+bug/658904
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  net/hub.c   | 7 +++----
>  net/slirp.c | 8 ++++----
>  net/tap.c   | 4 ++--
>  3 files changed, 9 insertions(+), 10 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2018-04-17  7:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  6:44 [Qemu-devel] [PATCH v3 for-2.13 0/3] net: Get rid of 'vlan' Thomas Huth
2018-04-16  6:44 ` [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter Thomas Huth
2018-04-17  7:21   ` Stefan Hajnoczi
2018-04-17  8:08     ` Thomas Huth
2018-04-17  9:48       ` Paolo Bonzini
2018-04-16  6:44 ` [Qemu-devel] [PATCH v3 for-2.13 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files Thomas Huth
2018-04-17  7:22   ` Stefan Hajnoczi [this message]
2018-04-16  6:44 ` [Qemu-devel] [PATCH v3 for-2.13 3/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files Thomas Huth
2018-04-17  7:25   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417072201.GK10770@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).