Re: [Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks

[Anthony PERARD <anthony.perard@citrix.com>]

On Tue, Apr 17, 2018 at 03:18:55PM +0100, Igor Druzhinin wrote:
> On 17/04/18 15:15, Anthony PERARD wrote:
> > On Fri, Apr 06, 2018 at 10:21:23PM +0100, Igor Druzhinin wrote:
> >> The issue that the original patch tried to workaround (uneven number of
> >> region_add/del calls on device attach/detach) was fixed in later QEMU
> >> versions.
> > 
> > Do you know when the issue was fixed?
> > 
> 
> I haven't tracked down a particular version but the previous behavior of
> memory_listener_unregister() was to remove the listener from the list
> without calling the callback. It has changed since then and now the
> callback is called in listener_del_address_space().

On Tue, Apr 17, 2018 at 03:29:42PM +0100, Igor Druzhinin wrote:
> I think it's this commit:
> 
> commit d25836cafd7508090d211e97acfc0abc5ae88daa
> Author: Peter Xu <peterx@redhat.com>
> Date:   Mon Jan 22 14:02:44 2018 +0800
> 
>     memory: do explicit cleanup when remove listeners


I think these information ought to be in the commit message, in
particular the fact that the callback wasn't call on detach. And with
the commit message updated, you can add my:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD