From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8rHn-0003N2-Lt for qemu-devel@nongnu.org; Wed, 18 Apr 2018 13:54:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8rHj-0005hV-3F for qemu-devel@nongnu.org; Wed, 18 Apr 2018 13:54:27 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55582 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8rHi-0005hF-Uj for qemu-devel@nongnu.org; Wed, 18 Apr 2018 13:54:23 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E29EB406E8C3 for ; Wed, 18 Apr 2018 17:54:18 +0000 (UTC) Date: Wed, 18 Apr 2018 19:54:12 +0200 From: Cornelia Huck Message-ID: <20180418195412.63a76412.cohuck@redhat.com> In-Reply-To: <20180418171151.5263-1-berrange@redhat.com> References: <20180418171151.5263-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] configure: add sanity check to catch builds from "git archive" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" Cc: qemu-devel@nongnu.org On Wed, 18 Apr 2018 18:11:51 +0100 Daniel P. Berrang=C3=A9 wrote: > The "git archive" feature creates tarballs which are missing all > submodule content. GitHub unhelpfully provides users with "Download" > links that claim to give them valid source release tarballs. These > GitHub archives will not be buildable as they are created by the > "git archive" feature and so are missing content. The user gets > unhelpful messages from make such as: >=20 > fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directo= ry >=20 > By adding a sanity check we can give users an informative message about > what they've done wrong. >=20 > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > configure | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/configure b/configure > index 0a19b033bc..089b00068c 100755 > --- a/configure > +++ b/configure > @@ -296,6 +296,24 @@ then > else > git_update=3Dno > git_submodules=3D"" > + > + if ! test -f "$source_path/ui/keycodemapdb/README" > + then > + echo > + echo "ERROR: missing file $source_path/ui/keycodemapdb/README" > + echo > + echo "This is not a GIT checkout but module content appears to" > + echo "be missing. Do not use 'git archive' or GitHub download li= nks" > + echo "to acquire QEMU source archives. Non-GIT builds are only" > + echo "supported with source archives linked from:" > + echo > + echo " https://www.qemu.org/download/" > + echo > + echo "Developers working with GIT can use scripts/archive-source= .sh" > + echo "if they need to create valid source archives." > + echo > + exit 1 > + fi > fi > git=3D"git" > =20 Reviewed-by: Cornelia Huck