From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-trivial@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/4] ui: switch gtk display to qapi parser
Date: Thu, 19 Apr 2018 15:20:25 +0200 [thread overview]
Message-ID: <20180419132026.5494-4-kraxel@redhat.com> (raw)
In-Reply-To: <20180419132026.5494-1-kraxel@redhat.com>
Drop the gtk option parser from parse_display(), so parse_display_qapi()
will handle it instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
vl.c | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/vl.c b/vl.c
index 39303d6b55..1123cd792e 100644
--- a/vl.c
+++ b/vl.c
@@ -2188,38 +2188,6 @@ static void parse_display(const char *p)
error_report("VNC requires a display argument vnc=<display>");
exit(1);
}
- } else if (strstart(p, "gtk", &opts)) {
- dpy.type = DISPLAY_TYPE_GTK;
- while (*opts) {
- const char *nextopt;
-
- if (strstart(opts, ",grab_on_hover=", &nextopt)) {
- opts = nextopt;
- dpy.u.gtk.has_grab_on_hover = true;
- if (strstart(opts, "on", &nextopt)) {
- dpy.u.gtk.grab_on_hover = true;
- } else if (strstart(opts, "off", &nextopt)) {
- dpy.u.gtk.grab_on_hover = false;
- } else {
- goto invalid_gtk_args;
- }
- } else if (strstart(opts, ",gl=", &nextopt)) {
- opts = nextopt;
- dpy.has_gl = true;
- if (strstart(opts, "on", &nextopt)) {
- dpy.gl = true;
- } else if (strstart(opts, "off", &nextopt)) {
- dpy.gl = false;
- } else {
- goto invalid_gtk_args;
- }
- } else {
- invalid_gtk_args:
- error_report("invalid GTK option string");
- exit(1);
- }
- opts = nextopt;
- }
} else {
parse_display_qapi(p);
}
--
2.9.3
next prev parent reply other threads:[~2018-04-19 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 13:20 [Qemu-devel] [PATCH 0/4] ui: use qapi-based parser for most -display options Gerd Hoffmann
2018-04-19 13:20 ` [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display Gerd Hoffmann
2018-04-19 15:57 ` Eric Blake
2018-04-19 19:57 ` Gerd Hoffmann
2018-07-26 12:45 ` Markus Armbruster
2018-08-24 6:30 ` Markus Armbruster
2018-08-24 6:51 ` Gerd Hoffmann
2018-08-27 10:02 ` Gerd Hoffmann
2018-04-19 13:20 ` [Qemu-devel] [PATCH 2/4] ui: switch trivial displays to qapi parser Gerd Hoffmann
2018-04-19 13:20 ` Gerd Hoffmann [this message]
2018-04-19 13:20 ` [Qemu-devel] [PATCH 4/4] ui: document non-qapi parser cases Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419132026.5494-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).