qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Emilio G. Cota" <cota@braap.org>
To: Peter Xu <peterx@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex
Date: Thu, 19 Apr 2018 18:48:20 -0400	[thread overview]
Message-ID: <20180419224820.GA21323@flamenco> (raw)
In-Reply-To: <20180419194301.GA22127@flamenco>

On Thu, Apr 19, 2018 at 15:43:01 -0400, Emilio G. Cota wrote:
> BTW you might also want to add the file/line pair to
> qemu-thread-win32.c, or hide the configure option to Windows
> users.

A few other call sites are missing as well, e.g. when returning from
pthread_cond_wait or with _trylock.

If you grep for trace_qemu_mutex_locked you'll find all the
places where the file/line update should occur.

		Emilio

  reply	other threads:[~2018-04-19 22:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  9:06 [Qemu-devel] [PATCH v2] QemuMutex: support --enable-debug-mutex Peter Xu
2018-04-19  1:56 ` Fam Zheng
2018-04-19  3:13   ` Peter Xu
2018-04-19 19:43     ` Emilio G. Cota
2018-04-19 22:48       ` Emilio G. Cota [this message]
2018-04-20  2:30       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419224820.GA21323@flamenco \
    --to=cota@braap.org \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).