From: Fam Zheng <famz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross
Date: Fri, 20 Apr 2018 10:57:59 +0800 [thread overview]
Message-ID: <20180420025759.GD17690@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180420024005.30245-1-f4bug@amsat.org>
On Thu, 04/19 23:40, Philippe Mathieu-Daudé wrote:
> Like the other images, this one is also used to cross-compile.
> Name it accordingly, matching directory pattern.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/Makefile.include | 2 +-
> .../{debian-amd64.docker => debian-amd64-cross.docker} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tests/docker/dockerfiles/{debian-amd64.docker => debian-amd64-cross.docker} (100%)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index de87341528..a113a15f77 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -49,7 +49,7 @@ docker-image-debian-powerpc-cross: EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerf
> # Enforce dependancies for composite images
> docker-image-debian: docker-image-debian9
> docker-image-debian8-mxe: docker-image-debian8
> -docker-image-debian-amd64: docker-image-debian9
> +docker-image-debian-amd64-cross: docker-image-debian9
> docker-image-debian-armel-cross: docker-image-debian9
> docker-image-debian-armhf-cross: docker-image-debian9
> docker-image-debian-arm64-cross: docker-image-debian9
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64-cross.docker
> similarity index 100%
> rename from tests/docker/dockerfiles/debian-amd64.docker
> rename to tests/docker/dockerfiles/debian-amd64-cross.docker
But the dockerfile is written differently: it doesn't use the --cross-prefix
configure option, plus, amd64 is usually the "native" arch making it non-cross
build.
What do you need this patch for beside the consistency?
Fam
next prev parent reply other threads:[~2018-04-20 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 2:40 [Qemu-devel] [PATCH] docker: Rename the amd64 image as amd64-cross Philippe Mathieu-Daudé
2018-04-20 2:57 ` Fam Zheng [this message]
2018-04-20 3:41 ` Philippe Mathieu-Daudé
2018-04-20 8:23 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420025759.GD17690@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).