From: Stefan Hajnoczi <stefanha@gmail.com>
To: Nikhil Balachandra <nikhilbalachandra.inbox@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD
Date: Fri, 20 Apr 2018 16:48:32 +0800 [thread overview]
Message-ID: <20180420084832.GT15181@stefanha-x1.localdomain> (raw)
In-Reply-To: <CAAGXMmLL2TBmNDqtVjp7y56WT6NadmX8X4HMBhXaWX6jJnirDg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Tue, Apr 17, 2018 at 09:57:46AM +0530, Nikhil Balachandra wrote:
> Hi Stefan,
>
> Thanks for the review. I'll be sending v2 version of this patch in next 3-4
> days with the following changes.
>
> 1) New scripts/update-xnu-headers.sh script to import if_bridgevar.h[4]
> into include/standard-headers/xnu directory.
> @qemu-devel - Please let me know if there is a better approach.
> 2) Fix broken vnet hdr in this patch.
> 3) Having minimal code in qemu-bridge-helper.c to open tap device instead
> of using tap_open().
>
> [4] - macOS if_bridgevar.h header file has APSL and BSD license.
Great, thank you!
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-04-20 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 19:42 [Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD Nikhil Balachandra
2018-04-16 7:31 ` Stefan Hajnoczi
2018-04-17 4:27 ` Nikhil Balachandra
2018-04-20 8:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420084832.GT15181@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=nikhilbalachandra.inbox@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).