From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Sh3-00077H-Pj for qemu-devel@nongnu.org; Fri, 20 Apr 2018 05:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9Sgz-00034s-QS for qemu-devel@nongnu.org; Fri, 20 Apr 2018 05:51:01 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47920 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f9Sgz-00034C-L8 for qemu-devel@nongnu.org; Fri, 20 Apr 2018 05:50:57 -0400 Date: Fri, 20 Apr 2018 10:50:53 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180420095053.GG21035@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180417224054.26363-1-lersek@redhat.com> <87po2wzysh.fsf@dusky.pond.sub.org> <8a52bb49-4194-3b91-8b67-a0e5700fd6ed@redhat.com> <87in8nvdpn.fsf@dusky.pond.sub.org> <20180419075629.GC10259@redhat.com> <5ed8b01f-7faa-b23d-5fd2-f4715294e061@redhat.com> <20180419091201.GI10259@redhat.com> <20180420093457.GE21035@redhat.com> <20180420094624.ltkg2jbugvgi4de5@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180420094624.ltkg2jbugvgi4de5@sirius.home.kraxel.org> Subject: Re: [Qemu-devel] [libvirt] [qemu RFC v2] qapi: add "firmware.json" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Laszlo Ersek , Markus Armbruster , Peter Maydell , Thomas Huth , Peter Krempa , Ard Biesheuvel , libvir-list@redhat.com, Michal Privoznik , qemu-devel@nongnu.org, Alexander Graf , Gary Ching-Pang Lin , Paolo Bonzini , David Gibson On Fri, Apr 20, 2018 at 11:46:24AM +0200, Gerd Hoffmann wrote: > Hi, > > > Since your schema is likely to end up just being a file in docs/specs, > > rather than directly part of our existnig qapi schema, I suggest we just > > ignore whats there. Just define an arch enum in your spec which is right, > > and let someone else worry about fixing the mess > > I think it would be useful to have this as part of the schema. Should > be easy then to write up a small utility then which takes a json file as > input and translates that into qemu command line options. Currently we have two distinct QAPI schemas, one covering the system emulator for QMP and subset of CLI args, and one covering the guest agent. This new schema isn't mapping to anything in QMP / CLI right now though. It can be used to decide how to generate CLI args, but it isn't describing those CLI args. So to me this is a 3rd distinct schema. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|