From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: benh@kernel.crashing.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT
Date: Fri, 20 Apr 2018 22:57:00 +1000 [thread overview]
Message-ID: <20180420125700.GU2434@umbus.fritz.box> (raw)
In-Reply-To: <20180420133414.434f8bab@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Fri, Apr 20, 2018 at 01:34:14PM +0200, Greg Kurz wrote:
> On Tue, 17 Apr 2018 17:17:15 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized
> > based on on ppc64_radix_guest(). Which seems reasonable, except that
> > ppc64_radix_guest() is based on spapr->patb_entry which is only set up
> > in spapr_machine_reset, called much later than cpu_ppc_set_papr().
> >
> > So the initialization here is pointless. The base cpu initialization
> > already sets a value that's good enough until the guest uses an hcall to
> > configure it's preferred MMU mode.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
Merged to ppc-for-2.13.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-20 13:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 7:17 [Qemu-devel] [PATCH for-2.13 00/10] spapr: Cleanups to PAPR mode setup David Gibson
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 01/10] spapr: Avoid redundant calls to spapr_cpu_reset() David Gibson
2018-04-19 13:48 ` Greg Kurz
2018-04-20 6:34 ` David Gibson
2018-04-20 9:15 ` Greg Kurz
2018-04-20 15:39 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-06-18 3:42 ` David Gibson
2018-06-18 9:01 ` Greg Kurz
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type David Gibson
2018-04-19 17:21 ` Greg Kurz
2018-04-20 5:58 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-04-20 6:40 ` [Qemu-devel] " David Gibson
2018-04-20 6:48 ` [Qemu-devel] [Qemu-ppc] " luigi burdo
2018-04-20 7:15 ` David Gibson
2018-04-20 12:25 ` [Qemu-devel] " Greg Kurz
2018-05-03 6:23 ` David Gibson
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT David Gibson
2018-04-20 11:34 ` Greg Kurz
2018-04-20 12:57 ` David Gibson [this message]
2018-04-25 9:52 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2018-04-26 6:46 ` David Gibson
2018-04-26 7:20 ` Cédric Le Goater
2018-05-01 6:39 ` David Gibson
2018-05-01 15:59 ` Cédric Le Goater
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 04/10] spapr: Set compatibility mode before the rest of spapr_cpu_reset() David Gibson
2018-04-20 9:16 ` Greg Kurz
2018-04-20 10:48 ` David Gibson
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 05/10] spapr: Move PAPR mode register initialization to spapr code David Gibson
2018-04-20 15:42 ` Greg Kurz
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 06/10] target/ppc: Add ppc_store_lpcr() helper David Gibson
2018-04-20 15:46 ` Greg Kurz
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 07/10] spapr: Make a helper to set up cpu entry point state David Gibson
2018-04-20 15:48 ` Greg Kurz
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 08/10] spapr: Clean up handling of LPCR power-saving exit bits David Gibson
2018-04-20 15:56 ` Greg Kurz
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 09/10] target/ppc: Don't bother with MSR_EP in cpu_ppc_set_papr() David Gibson
2018-04-20 6:08 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-04-20 6:21 ` David Gibson
2018-04-17 7:17 ` [Qemu-devel] [PATCH for-2.13 10/10] spapr: Move PAPR specific cpu logic to pseries machine type David Gibson
2018-04-20 15:58 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420125700.GU2434@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).