From: "Emilio G. Cota" <cota@braap.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
peter.maydell@linaro.org, richard.henderson@linaro.org,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code
Date: Fri, 20 Apr 2018 16:02:20 -0400 [thread overview]
Message-ID: <20180420200220.GA517@flamenco> (raw)
In-Reply-To: <9b39de2c-5682-bbbc-43f9-cc3397ea6e93@amsat.org>
On Fri, Apr 20, 2018 at 16:11:35 -0300, Philippe Mathieu-Daudé wrote:
> On 04/20/2018 03:35 PM, Emilio G. Cota wrote:
> > I also changed the patches to make the series simpler: one patch
> > to add softmmu.c (without compiling it yet), one patch to
> > actually use softmmu.c, and a final patch to remove the template
> > file.
>
> By "without compiling" you mean it is not compilable?
> That would mean not script-bisectable.
I mean it's committed but not yet buildable, i.e. makefiles
don't know anything about it. (So no, the build isn't broken.)
The point is to make the diff's as easy to review as possible.
> > The executable is now larger:
>
> This is odd, I was expecting some shrinking...
>
> What kind of build are doing? More such -ggdb or such -O3?
I'm using the defaults.
Why would you expect a size reduction? With flatten we tell the
compiler to expand everything it can, so it makes sense that
it leads to larger code size vs. letting the compiler decide
what (or not) to inline.
Cheers,
Emilio
next prev parent reply other threads:[~2018-04-20 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 15:50 [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 1/6] accel/tcg: export some cputlb functions Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 2/6] accel/tcg: new softmmu.c with DATA_SIZE=1 Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 3/6] accel/tcg: add DATA_SIZE = 2 to softmmu Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 4/6] accel/tcg: create load_helper Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 5/6] accel/tcg: create store_helper Alex Bennée
2018-04-20 15:50 ` [Qemu-devel] [RFC PATCH 6/6] accel/tcg: convert 4/8 byte access and remove softmmu_template Alex Bennée
2018-04-20 21:36 ` Richard Henderson
2018-04-20 16:01 ` [Qemu-devel] [RFC PATCH 0/6] Convert softmmu-template into normal code no-reply
2018-04-20 16:05 ` no-reply
2018-04-20 16:16 ` Paolo Bonzini
2018-04-20 16:22 ` Peter Maydell
2018-04-20 16:26 ` no-reply
2018-04-20 18:35 ` Emilio G. Cota
2018-04-20 18:43 ` Alex Bennée
2018-04-20 19:11 ` Philippe Mathieu-Daudé
2018-04-20 20:02 ` Emilio G. Cota [this message]
2018-04-20 19:17 ` Alex Bennée
2018-04-23 10:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420200220.GA517@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).