qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org, cota@braap.org, famz@redhat.com,
	berrange@redhat.com, f4bug@amsat.org,
	richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v3 18/46] tests/tcg: enable building for i386
Date: Tue, 24 Apr 2018 16:23:37 +0100	[thread overview]
Message-ID: <20180424152405.10304-19-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180424152405.10304-1-alex.bennee@linaro.org>

While you can construct a compile command that does work using the
x86_64 host compiler that most people use this is flakey. Different
distros handle this is different ways so we default to using a known
good i386 compiler via docker.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v3
  - add runner for runcom
---
 tests/tcg/i386/Makefile.include | 9 +++++++++
 tests/tcg/i386/Makefile.target  | 9 +++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 tests/tcg/i386/Makefile.include

diff --git a/tests/tcg/i386/Makefile.include b/tests/tcg/i386/Makefile.include
new file mode 100644
index 0000000000..be1c3008dd
--- /dev/null
+++ b/tests/tcg/i386/Makefile.include
@@ -0,0 +1,9 @@
+#
+# Makefile.include for all i386
+#
+# There is enough brokeness in x86_64 compilers that we don't default
+# to using the x86_64 system compiler for i386 binaries.
+#
+
+DOCKER_IMAGE=fedora-i386-cross
+DOCKER_CROSS_COMPILER=gcc
diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
index 2f27b65e2d..39a1627650 100644
--- a/tests/tcg/i386/Makefile.target
+++ b/tests/tcg/i386/Makefile.target
@@ -28,3 +28,12 @@ hello-i386: LDFLAGS+=-nostdlib
 test-i386: test-i386.c test-i386-code16.S test-i386-vm86.S test-i386.h test-i386-shift.h test-i386-muldiv.h
 	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ \
 	   $(<D)/test-i386.c $(<D)/test-i386-code16.S $(<D)/test-i386-vm86.S -lm
+
+# Specialist test runners
+.PHONY: pi_10.com
+pi_10.com:
+	cp $(I386_SRC)/pi_10.com .
+
+run-runcom: runcom pi_10.com
+	$(call quiet-command, $(QEMU) ./runcom ./pi_10.com > runcom.out, "TEST", "$< on $(TARGET_NAME)")
+
-- 
2.17.0

  parent reply	other threads:[~2018-04-24 15:43 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:23 [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 01/46] docker: add "probe" command for configure Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 02/46] configure: add test for docker availability Alex Bennée
2018-04-25  0:06   ` Richard Henderson
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 03/46] configure: add support for --cross-cc-FOO Alex Bennée
2018-04-25  0:10   ` Richard Henderson
2018-04-25  9:10     ` Alex Bennée
2018-04-25 16:27   ` Murilo Opsfelder Araujo
2018-05-16 15:18     ` Alex Bennée
2018-05-16 17:36       ` Murilo Opsfelder Araujo
2018-05-16 20:37         ` Alex Bennée
2018-04-25 17:03   ` Peter Maydell
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 04/46] configure: move i386_cc to cross_cc_i386 Alex Bennée
2018-04-25  0:11   ` Richard Henderson
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 05/46] configure: allow user to specify --cross-cc-cflags-foo= Alex Bennée
2018-04-25  0:12   ` Richard Henderson
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 06/46] configure: set cross_cc_FOO for host compiler Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 07/46] Makefile: Rename TARGET_DIRS to TARGET_LIST Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 08/46] docker: Add "cc" subcommand Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 09/46] docker: extend "cc" command to accept compiler Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 10/46] docker: allow "cc" command to run in user context Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 11/46] docker: Makefile.include introduce DOCKER_SCRIPT Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 12/46] tests/tcg: move architecture independent tests into subdir Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 13/46] tests/tcg/multiarch: Build fix for linux-test Alex Bennée
2018-04-25  0:13   ` Richard Henderson
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 14/46] tests/tcg/multiarch: enable additional linux-test tests Alex Bennée
2018-04-25  0:14   ` Richard Henderson
2018-04-25  4:07   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 15/46] tests/tcg/multiarch: move most output to stdout Alex Bennée
2018-04-25  0:14   ` Richard Henderson
2018-04-25  4:06   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 16/46] tests/tcg: move i386 specific tests into subdir Alex Bennée
2018-04-25  0:15   ` Richard Henderson
2018-04-25  3:27   ` Philippe Mathieu-Daudé
2018-04-25  9:08     ` Alex Bennée
2018-04-25 13:42       ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 17/46] docker: Add fedora-i386-cross image Alex Bennée
2018-04-24 23:04   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` Alex Bennée [this message]
2018-04-25  3:33   ` [Qemu-devel] [PATCH v3 18/46] tests/tcg: enable building for i386 Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 19/46] tests/tcg/i386: Build fix for hello-i386 Alex Bennée
2018-04-25  0:22   ` Richard Henderson
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 20/46] tests/tcg/i386: fix test-i386 Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 21/46] tests/tcg/i386: fix test-i386-fprem Alex Bennée
2018-04-25  0:23   ` Richard Henderson
2018-04-25  3:26   ` Thomas Huth
2018-04-25  8:46     ` Alex Bennée
2018-04-25  3:42   ` Philippe Mathieu-Daudé
2018-04-25  8:45     ` Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 22/46] tests/tcg/i386: disable i386 version of test-i386-ssse Alex Bennée
2018-04-25 21:28   ` Richard Henderson
2018-04-26  8:59     ` Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 23/46] tests/tcg/x86_64: add Makefile.target Alex Bennée
2018-04-25  4:03   ` Philippe Mathieu-Daudé
2018-04-25  8:43     ` Alex Bennée
2018-04-25 14:01       ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 24/46] tests/tcg/i386/test-i386: use modern vector_size attributes Alex Bennée
2018-04-25  3:47   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 25/46] tests/tcg/i386/test-i386: fix printf format Alex Bennée
2018-04-25 14:06   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 26/46] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 27/46] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-04-25  3:48   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-04-25  3:57   ` Philippe Mathieu-Daudé
2018-04-25  8:43     ` Alex Bennée
2018-04-25 14:21       ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 29/46] tests/tcg/aarch64: add fcvt test cases for AArch64 Alex Bennée
2018-04-25 14:22   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 30/46] tests/tcg: move MIPS specific tests into subdir Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 31/46] tests/tcg: enable building for MIPS Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 32/46] tests/tcg/mips: include common mips hello-mips Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 33/46] tests/tcg: enable building for s390x Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 34/46] tests/tcg: enable building for ppc64 Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 35/46] tests/tcg: enable building for Alpha Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 36/46] tests/tcg/alpha: add Alpha specific tests Alex Bennée
2018-04-24 18:28   ` Richard Henderson
2018-04-25  9:11     ` Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 37/46] tests/tcg/alpha: fix warnings about write() Alex Bennée
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 38/46] tests/tcg: enable building for HPPA Alex Bennée
2018-04-25 14:08   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 39/46] tests/tcg: enable building for m68k Alex Bennée
2018-04-25 14:28   ` Philippe Mathieu-Daudé
2018-04-24 15:23 ` [Qemu-devel] [PATCH v3 40/46] tests/tcg: enable building for sh4 Alex Bennée
2018-04-25 14:16   ` Philippe Mathieu-Daudé
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 41/46] tests/tcg: enable building for sparc64 Alex Bennée
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 42/46] tests/tcg: enable building for mips64 Alex Bennée
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 43/46] tests/tcg/Makefile: update to be called from Makefile.target Alex Bennée
2018-04-25 21:26   ` Richard Henderson
2018-04-26  9:30     ` Alex Bennée
2018-04-26 20:51       ` Richard Henderson
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 44/46] Makefile.target: add (clean-)guest-tests targets Alex Bennée
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 45/46] tests/Makefile.include: add [build|clean|check]-tcg targets Alex Bennée
2018-04-24 23:13   ` Philippe Mathieu-Daudé
2018-04-25 14:15     ` Philippe Mathieu-Daudé
2018-04-25 15:40       ` Alex Bennée
2018-04-25  3:18   ` Philippe Mathieu-Daudé
2018-04-24 15:24 ` [Qemu-devel] [PATCH v3 46/46] tests/tcg: override runners for broken tests (!UPSTREAM) Alex Bennée
2018-04-24 16:58 ` [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg no-reply
2018-04-25  1:25 ` Philippe Mathieu-Daudé
2018-04-25  6:57   ` Samuel Thibault
2018-04-25  8:39     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424152405.10304-19-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).